xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Egger, Christoph" <chegger@amazon.de>
To: Haozhong Zhang <haozhong.zhang@intel.com>, xen-devel@lists.xen.org
Cc: Wei Liu <wei.liu2@citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Liu Jinsong <jinsong.liu@alibaba-inc.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Keir Fraser <keir@xen.org>
Subject: Re: [PATCH 2/4] tools/mceinject: Fix code style
Date: Tue, 15 Sep 2015 10:48:24 +0200	[thread overview]
Message-ID: <55F7DB58.8020405@amazon.de> (raw)
In-Reply-To: <1442305780-12790-3-git-send-email-haozhong.zhang@intel.com>

On 2015/09/15 10:29, Haozhong Zhang wrote:
> Remove trailing spaces in xen-mceinj.c.
> 
> Signed-off-by: Haozhong Zhang <haozhong.zhang@intel.com>

Acked-by: Christoph Egger <chegger@amazon.de>

> ---
>  tools/tests/mce-test/tools/xen-mceinj.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/tools/tests/mce-test/tools/xen-mceinj.c b/tools/tests/mce-test/tools/xen-mceinj.c
> index e2e49cb..0c2b640 100644
> --- a/tools/tests/mce-test/tools/xen-mceinj.c
> +++ b/tools/tests/mce-test/tools/xen-mceinj.c
> @@ -13,7 +13,7 @@
>   *
>   * You should have received a copy of the GNU General Public License along with
>   * this program; If not, see <http://www.gnu.org/licenses/>.
> - * 
> + *
>   * Authors: Yunhong Jiang <yunhong.jiang@intel.com>
>   *          Haicheng Li <haicheng.li@intel.com>
>   *          Xudong Hao <xudong.hao@intel.com>
> @@ -300,7 +300,7 @@ static uint64_t guest_mfn(xc_interface *xc_handle,
>          return MCE_INVALID_MFN;
>  
>      /* Get max gpfn */
> -    max_gpfn = do_memory_op(xc_handle, XENMEM_maximum_gpfn, &domain, 
> +    max_gpfn = do_memory_op(xc_handle, XENMEM_maximum_gpfn, &domain,
>                                 sizeof(domain)) + 1;
>      if ( max_gpfn <= 0 )
>          err(xc_handle, "Failed to get max_gpfn 0x%lx", max_gpfn);
> @@ -360,7 +360,7 @@ static uint64_t mca_gpfn_to_mfn(xc_interface *xc_handle,
>      if ( domain == DOMID_XEN )
>          return gfn;
>  
> -    max_gpfn = do_memory_op(xc_handle, XENMEM_maximum_gpfn, &domain, 
> +    max_gpfn = do_memory_op(xc_handle, XENMEM_maximum_gpfn, &domain,
>                                 sizeof(domain)) + 1;
>      if ( max_gpfn <= 0 )
>          err(xc_handle, "Failed to get max_gpfn 0x%lx", max_gpfn);
> @@ -383,7 +383,7 @@ static int inject_mci_status(xc_interface *xc_handle,
>                               uint64_t val)
>  {
>      return add_msr_bank_intpose(xc_handle, cpu_nr, MC_MSRINJ_F_INTERPOSE,
> -                                    MCi_type_STATUS, bank, val); 
> +                                    MCi_type_STATUS, bank, val);
>  }
>  
>  static int inject_mci_misc(xc_interface *xc_handle,
> @@ -392,7 +392,7 @@ static int inject_mci_misc(xc_interface *xc_handle,
>                               uint64_t val)
>  {
>      return add_msr_bank_intpose(xc_handle, cpu_nr, MC_MSRINJ_F_INTERPOSE,
> -                                    MCi_type_MISC, bank, val); 
> +                                    MCi_type_MISC, bank, val);
>  }
>  
>  static int inject_mci_addr(xc_interface *xc_handle,
> @@ -401,7 +401,7 @@ static int inject_mci_addr(xc_interface *xc_handle,
>                               uint64_t val)
>  {
>      return add_msr_bank_intpose(xc_handle, cpu_nr, MC_MSRINJ_F_INTERPOSE,
> -                                    MCi_type_ADDR, bank, val); 
> +                                    MCi_type_ADDR, bank, val);
>  }
>  
>  static int inject(xc_interface *xc_handle, struct mce_info *mce,
> @@ -553,7 +553,7 @@ int main(int argc, char *argv[])
>              return 0;
>          }
>      }
> -    
> +
>      if ( domid != DOMID_XEN ) {
>          max_gpa = xs_get_dom_mem(domid);
>          Lprintf("get domain %d max gpa is: 0x%lx", domid, max_gpa);
> @@ -570,7 +570,7 @@ int main(int argc, char *argv[])
>          haddr = (mfn << PAGE_SHIFT) | (gaddr & (PAGE_SIZE - 1));
>          if ( domid == DOMID_XEN )
>              Lprintf("Xen: mfn=0x%lx, haddr=0x%lx", mfn, haddr);
> -        else 
> +        else
>              Lprintf("Dom%d: gaddr=0x%lx, gpfn=0x%lx, mfn=0x%lx, haddr=0x%lx",
>                      domid, gaddr, gpfn, mfn, haddr);
>          goto out;
> 

Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger
Ust-ID: DE289237879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B

  reply	other threads:[~2015-09-15  8:48 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-15  8:29 [PATCH 0/4] Fix tools/xen-mceinj to handle >=4GB guest memory Haozhong Zhang
2015-09-15  8:29 ` [PATCH 1/4] x86/mce: Fix code style Haozhong Zhang
2015-09-15  8:47   ` Egger, Christoph
2015-09-15 13:13   ` Jan Beulich
2015-09-15 13:19     ` Haozhong Zhang
2015-09-15  8:29 ` [PATCH 2/4] tools/mceinject: " Haozhong Zhang
2015-09-15  8:48   ` Egger, Christoph [this message]
2015-09-15 10:15     ` Ian Campbell
2015-09-15 13:11   ` Wei Liu
2015-09-15  8:29 ` [PATCH 3/4] x86/mce: Translate passed-in GPA to host machine address Haozhong Zhang
2015-09-15  9:14   ` Egger, Christoph
2015-09-15  9:48     ` Haozhong Zhang
2015-09-15 13:24   ` Jan Beulich
2015-09-15 13:42     ` Haozhong Zhang
2015-09-15 13:47       ` Jan Beulich
2015-09-15 13:51         ` Haozhong Zhang
2015-09-15 13:50       ` Andrew Cooper
2015-09-16  0:38         ` Haozhong Zhang
2015-09-15  8:29 ` [PATCH 4/4] tools/xen-mceinj: Pass in GPA when injecting through MSR_MCI_ADDR Haozhong Zhang
2015-09-15 10:02   ` Wei Liu
2015-09-15 10:08     ` Egger, Christoph
2015-09-15 10:16       ` Wei Liu
2015-09-15 10:17   ` Egger, Christoph
2015-09-15 10:28     ` Haozhong Zhang
2015-09-15 10:34       ` Egger, Christoph
2015-09-15 10:20   ` Ian Campbell
2015-09-15 10:38     ` Haozhong Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F7DB58.8020405@amazon.de \
    --to=chegger@amazon.de \
    --cc=andrew.cooper3@citrix.com \
    --cc=haozhong.zhang@intel.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=jinsong.liu@alibaba-inc.com \
    --cc=keir@xen.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).