From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Egger, Christoph" Subject: Re: [PATCH 4/4] tools/xen-mceinj: Pass in GPA when injecting through MSR_MCI_ADDR Date: Tue, 15 Sep 2015 12:08:32 +0200 Message-ID: <55F7EE20.80504@amazon.de> References: <1442305780-12790-1-git-send-email-haozhong.zhang@intel.com> <1442305780-12790-5-git-send-email-haozhong.zhang@intel.com> <20150915100209.GJ2294@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150915100209.GJ2294@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu , Haozhong Zhang Cc: Keir Fraser , Ian Campbell , Stefano Stabellini , Liu Jinsong , Ian Jackson , xen-devel@lists.xen.org, Jan Beulich , Andrew Cooper List-Id: xen-devel@lists.xenproject.org On 2015/09/15 12:02, Wei Liu wrote: > I don't know this piece of code so my comments might be stupid. > > On Tue, Sep 15, 2015 at 04:29:40PM +0800, Haozhong Zhang wrote: >> This patch removes the address translation in xen-mceinj which >> translates the guest physical address passed-in through the argument >> of '-p' to the host machine address. >> > > Is the translation functionality broken or superseded by hardware > support? What is the reason for removing this piece of (working?) code? Neither nor. The translation done in xen-mceinj.c doesn't deal with memory addresses above 4G. The fix is to let the hypervisor do the translation. Christoph > > (I haven't looked at the code) > > Wei. > Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger Ust-ID: DE289237879 Eingetragen am Amtsgericht Charlottenburg HRB 149173 B