From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
Liu Jinsong <jinsong.liu@alibaba-inc.com>,
Christoph Egger <chegger@amazon.de>,
Ian Campbell <ian.campbell@citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
xen-devel@lists.xen.org, Keir Fraser <keir@xen.org>
Subject: Re: [PATCH 3/4] x86/mce: Translate passed-in GPA to host machine address
Date: Tue, 15 Sep 2015 14:50:27 +0100 [thread overview]
Message-ID: <55F82223.8010305@citrix.com> (raw)
In-Reply-To: <20150915134242.GA2747@hzzhang-OptiPlex-9020.sh.intel.com>
On 15/09/15 14:42, Haozhong Zhang wrote:
>
>>> + mfn = mfn_x(get_gfn(d, gpfn, &t));
>>> +
>>> + if (mfn == INVALID_MFN) {
>>> + put_domain(d);
>>> + return x86_mcerr("do_mca inject: illegal MSR value",
>>> + -EINVAL);
>> This message should be better distinguishable from the one further
>> down (or else it's pretty pointless) - perhaps you mean GPFN instead
>> of MSR?
>>
> Yes, I'll change it to "do_mca_inject: illegal GPFN".
Please always always always write useful error messages. "illegal GPFN"
is useless without also stating which value is believed to be invalid.
Furthermore, per the clarification in c/s e758ed1, "gfn" is the correct
term to use here.
~Andrew
next prev parent reply other threads:[~2015-09-15 13:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 8:29 [PATCH 0/4] Fix tools/xen-mceinj to handle >=4GB guest memory Haozhong Zhang
2015-09-15 8:29 ` [PATCH 1/4] x86/mce: Fix code style Haozhong Zhang
2015-09-15 8:47 ` Egger, Christoph
2015-09-15 13:13 ` Jan Beulich
2015-09-15 13:19 ` Haozhong Zhang
2015-09-15 8:29 ` [PATCH 2/4] tools/mceinject: " Haozhong Zhang
2015-09-15 8:48 ` Egger, Christoph
2015-09-15 10:15 ` Ian Campbell
2015-09-15 13:11 ` Wei Liu
2015-09-15 8:29 ` [PATCH 3/4] x86/mce: Translate passed-in GPA to host machine address Haozhong Zhang
2015-09-15 9:14 ` Egger, Christoph
2015-09-15 9:48 ` Haozhong Zhang
2015-09-15 13:24 ` Jan Beulich
2015-09-15 13:42 ` Haozhong Zhang
2015-09-15 13:47 ` Jan Beulich
2015-09-15 13:51 ` Haozhong Zhang
2015-09-15 13:50 ` Andrew Cooper [this message]
2015-09-16 0:38 ` Haozhong Zhang
2015-09-15 8:29 ` [PATCH 4/4] tools/xen-mceinj: Pass in GPA when injecting through MSR_MCI_ADDR Haozhong Zhang
2015-09-15 10:02 ` Wei Liu
2015-09-15 10:08 ` Egger, Christoph
2015-09-15 10:16 ` Wei Liu
2015-09-15 10:17 ` Egger, Christoph
2015-09-15 10:28 ` Haozhong Zhang
2015-09-15 10:34 ` Egger, Christoph
2015-09-15 10:20 ` Ian Campbell
2015-09-15 10:38 ` Haozhong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F82223.8010305@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=chegger@amazon.de \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jinsong.liu@alibaba-inc.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).