xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	dgdegra@tycho.nsa.gov, xen-devel@lists.xenproject.org
Subject: Re: [PATCH] xen/xsm: Shut up GCC 5.1.1 warnings.
Date: Wed, 16 Sep 2015 20:05:52 +0100	[thread overview]
Message-ID: <55F9BD90.3060708@citrix.com> (raw)
In-Reply-To: <1442423562-6595-1-git-send-email-konrad.wilk@oracle.com>

On 16/09/2015 18:12, Konrad Rzeszutek Wilk wrote:
> policydb.c: In function ‘user_read’:
> policydb.c:1443:26: error: ‘buf[2]’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
>          usrdatum->bounds = le32_to_cpu(buf[2]);
>                           ^
> cc1: all warnings being treated as errors
>
> Which makes no sense, as :
>  1). A couple of lines above it is being filled (buf[2]).
>  2). There are other instances of this which are not triggering this
>      failure.
>
> But GCC insists, and this patch stops the failures.
>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

A better bet would just be to initialise buf at declaration time, so
"__le32 buf[3] = { 0 };"

The reason this warning is firing is that C may not assume that
p->policyvers doesn't change between the next_entry() call and the
role->bounds assignment.  Pulling p->policyvers into a local variable
might also be sufficient.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2015-09-16 19:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-16 17:12 [PATCH] xen/xsm: Shut up GCC 5.1.1 warnings Konrad Rzeszutek Wilk
2015-09-16 19:05 ` Andrew Cooper [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-09-16 13:45 Konrad Rzeszutek Wilk
2015-09-16 15:14 ` Julien Grall
2015-09-16 16:18   ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F9BD90.3060708@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=dgdegra@tycho.nsa.gov \
    --cc=konrad.wilk@oracle.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).