Re: [PATCH] Add missing license and copyright statements to public interface headers.

[Boris Ostrovsky <boris.ostrovsky@oracle.com>]

On 09/18/2015 04:44 AM, Ian Campbell wrote:
> On Thu, 2015-09-17 at 13:53 +0200, Mike Belopuhov wrote:
>
> A few words here about the methodology you used to determine the names to
> use would be useful to people looking back on this stuff in the future.
>
> Also it would be sensible to CC everyone whose name you are adding. I've
> added Keir since you already Ccd Boris and I didn't see any other names
> after a quick glance.

For changes that include my name (pmu files)
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

Not sure about format --- files in public directory largely use the same 
format as what Mike is suggesting here but most of newer files do what 
Konrad said (i.e. "Author" on a separate line).

We will also want to apply similar patch to Linux tree (once this is 
done). Mike, do you mind doing it too?

-boris

>
> Ian.
>
>> Signed-off-by: Mike Belopuhov <mike.belopuhov@esdenera.com>
>> ---
>>   xen/include/public/arch-x86/pmu.h       | 22 ++++++++++++++++++++++
>>   xen/include/public/hvm/e820.h           |  3 ++-
>>   xen/include/public/hvm/hvm_info_table.h |  2 ++
>>   xen/include/public/hvm/hvm_op.h         |  2 ++
>>   xen/include/public/hvm/hvm_xs_strings.h |  2 ++
>>   xen/include/public/hvm/params.h         |  2 ++
>>   xen/include/public/io/protocols.h       |  2 ++
>>   xen/include/public/physdev.h            |  2 ++
>>   xen/include/public/pmu.h                | 22 ++++++++++++++++++++++
>>   9 files changed, 58 insertions(+), 1 deletion(-)
>>
>> diff --git xen/include/public/arch-x86/pmu.h xen/include/public/arch
>> -x86/pmu.h
>> index 1a53888..cb05121 100644
>> --- xen/include/public/arch-x86/pmu.h
>> +++ xen/include/public/arch-x86/pmu.h
>> @@ -1,5 +1,27 @@
>> +/*
>> + * Permission is hereby granted, free of charge, to any person obtaining
>> a copy
>> + * of this software and associated documentation files (the "Software"),
>> to
>> + * deal in the Software without restriction, including without
>> limitation the
>> + * rights to use, copy, modify, merge, publish, distribute, sublicense,
>> and/or
>> + * sell copies of the Software, and to permit persons to whom the
>> Software is
>> + * furnished to do so, subject to the following conditions:
>> + *
>> + * The above copyright notice and this permission notice shall be
>> included in
>> + * all copies or substantial portions of the Software.
>> + *
>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
>> EXPRESS OR
>> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
>> MERCHANTABILITY,
>> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
>> SHALL THE
>> + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
>> OTHER
>> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>> ARISING
>> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>> + * DEALINGS IN THE SOFTWARE.
>> + *
>> + * Copyright (c) 2015, Boris Ostrovsky, Oracle Corp.
>> + */
>> +
>>   #ifndef __XEN_PUBLIC_ARCH_X86_PMU_H__
>>   #define __XEN_PUBLIC_ARCH_X86_PMU_H__
>>   
>>   /* x86-specific PMU definitions */
>>   
>> diff --git xen/include/public/hvm/e820.h xen/include/public/hvm/e820.h
>> index 5bdc227..6c58a37 100644
>> --- xen/include/public/hvm/e820.h
>> +++ xen/include/public/hvm/e820.h
>> @@ -1,6 +1,5 @@
>> -
>>   /*
>>    * Permission is hereby granted, free of charge, to any person obtaining
>> a copy
>>    * of this software and associated documentation files (the "Software"),
>> to
>>    * deal in the Software without restriction, including without
>> limitation the
>>    * rights to use, copy, modify, merge, publish, distribute, sublicense,
>> and/or
>> @@ -15,10 +14,12 @@
>>    * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
>> SHALL THE
>>    * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
>> OTHER
>>    * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>> ARISING
>>    * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>>    * DEALINGS IN THE SOFTWARE.
>> + *
>> + * Copyright (c) 2006, Keir Fraser
>>    */
>>   
>>   #ifndef __XEN_PUBLIC_HVM_E820_H__
>>   #define __XEN_PUBLIC_HVM_E820_H__
>>   
>> diff --git xen/include/public/hvm/hvm_info_table.h
>> xen/include/public/hvm/hvm_info_table.h
>> index 36085fa..9e3f807 100644
>> --- xen/include/public/hvm/hvm_info_table.h
>> +++ xen/include/public/hvm/hvm_info_table.h
>> @@ -18,10 +18,12 @@
>>    * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
>> SHALL THE
>>    * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
>> OTHER
>>    * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>> ARISING
>>    * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>>    * DEALINGS IN THE SOFTWARE.
>> + *
>> + * Copyright (c) 2006, Keir Fraser
>>    */
>>   
>>   #ifndef __XEN_PUBLIC_HVM_HVM_INFO_TABLE_H__
>>   #define __XEN_PUBLIC_HVM_HVM_INFO_TABLE_H__
>>   
>> diff --git xen/include/public/hvm/hvm_op.h
>> xen/include/public/hvm/hvm_op.h
>> index 014546a..1606185 100644
>> --- xen/include/public/hvm/hvm_op.h
>> +++ xen/include/public/hvm/hvm_op.h
>> @@ -14,10 +14,12 @@
>>    * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
>> SHALL THE
>>    * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
>> OTHER
>>    * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>> ARISING
>>    * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>>    * DEALINGS IN THE SOFTWARE.
>> + *
>> + * Copyright (c) 2007, Keir Fraser
>>    */
>>   
>>   #ifndef __XEN_PUBLIC_HVM_HVM_OP_H__
>>   #define __XEN_PUBLIC_HVM_HVM_OP_H__
>>   
>> diff --git xen/include/public/hvm/hvm_xs_strings.h
>> xen/include/public/hvm/hvm_xs_strings.h
>> index 8aec935..146b0b0 100644
>> --- xen/include/public/hvm/hvm_xs_strings.h
>> +++ xen/include/public/hvm/hvm_xs_strings.h
>> @@ -18,10 +18,12 @@
>>    * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
>> SHALL THE
>>    * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
>> OTHER
>>    * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>> ARISING
>>    * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>>    * DEALINGS IN THE SOFTWARE.
>> + *
>> + * Copyright (c) 2013, Citrix Systems
>>    */
>>   
>>   #ifndef __XEN_PUBLIC_HVM_HVM_XS_STRINGS_H__
>>   #define __XEN_PUBLIC_HVM_HVM_XS_STRINGS_H__
>>   
>> diff --git xen/include/public/hvm/params.h
>> xen/include/public/hvm/params.h
>> index 147d9b8..356dfd3 100644
>> --- xen/include/public/hvm/params.h
>> +++ xen/include/public/hvm/params.h
>> @@ -14,10 +14,12 @@
>>    * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
>> SHALL THE
>>    * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
>> OTHER
>>    * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>> ARISING
>>    * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>>    * DEALINGS IN THE SOFTWARE.
>> + *
>> + * Copyright (c) 2007, Keir Fraser
>>    */
>>   
>>   #ifndef __XEN_PUBLIC_HVM_PARAMS_H__
>>   #define __XEN_PUBLIC_HVM_PARAMS_H__
>>   
>> diff --git xen/include/public/io/protocols.h
>> xen/include/public/io/protocols.h
>> index 80b196b..40a9b30 100644
>> --- xen/include/public/io/protocols.h
>> +++ xen/include/public/io/protocols.h
>> @@ -16,10 +16,12 @@
>>    * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
>> SHALL THE
>>    * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
>> OTHER
>>    * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>> ARISING
>>    * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>>    * DEALINGS IN THE SOFTWARE.
>> + *
>> + * Copyright (c) 2008, Keir Fraser
>>    */
>>   
>>   #ifndef __XEN_PROTOCOLS_H__
>>   #define __XEN_PROTOCOLS_H__
>>   
>> diff --git xen/include/public/physdev.h xen/include/public/physdev.h
>> index c9be6de..0e54635 100644
>> --- xen/include/public/physdev.h
>> +++ xen/include/public/physdev.h
>> @@ -14,10 +14,12 @@
>>    * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
>> SHALL THE
>>    * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
>> OTHER
>>    * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>> ARISING
>>    * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>>    * DEALINGS IN THE SOFTWARE.
>> + *
>> + * Copyright (c) 2006, Keir Fraser
>>    */
>>   
>>   #ifndef __XEN_PUBLIC_PHYSDEV_H__
>>   #define __XEN_PUBLIC_PHYSDEV_H__
>>   
>> diff --git xen/include/public/pmu.h xen/include/public/pmu.h
>> index 1149678..8d16b30 100644
>> --- xen/include/public/pmu.h
>> +++ xen/include/public/pmu.h
>> @@ -1,5 +1,27 @@
>> +/*
>> + * Permission is hereby granted, free of charge, to any person obtaining
>> a copy
>> + * of this software and associated documentation files (the "Software"),
>> to
>> + * deal in the Software without restriction, including without
>> limitation the
>> + * rights to use, copy, modify, merge, publish, distribute, sublicense,
>> and/or
>> + * sell copies of the Software, and to permit persons to whom the
>> Software is
>> + * furnished to do so, subject to the following conditions:
>> + *
>> + * The above copyright notice and this permission notice shall be
>> included in
>> + * all copies or substantial portions of the Software.
>> + *
>> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
>> EXPRESS OR
>> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
>> MERCHANTABILITY,
>> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
>> SHALL THE
>> + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
>> OTHER
>> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>> ARISING
>> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
>> + * DEALINGS IN THE SOFTWARE.
>> + *
>> + * Copyright (c) 2015, Boris Ostrovsky, Oracle Corp.
>> + */
>> +
>>   #ifndef __XEN_PUBLIC_PMU_H__
>>   #define __XEN_PUBLIC_PMU_H__
>>   
>>   #include "xen.h"
>>   #if defined(__i386__) || defined(__x86_64__)