From: Dario Faggioli <dario.faggioli@citrix.com>
To: xen-devel@lists.xen.org
Cc: Andre Przywara <andre.przywara@amd.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Ian Campbell <Ian.Campbell@citrix.com>
Subject: [PATCH 2 of 3] libxl, xl: user can ask for min and max nodes to use during placement
Date: Tue, 16 Oct 2012 19:26:27 +0200 [thread overview]
Message-ID: <55f27c485238772388bb.1350408387@Solace> (raw)
In-Reply-To: <patchbomb.1350408385@Solace>
And the placement algorithm will stick to that, or fail. This happens
adding support for "minnodes=" and "maxnodes=" in the domain config
file parser.
Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
diff --git a/docs/man/xl.cfg.pod.5 b/docs/man/xl.cfg.pod.5
--- a/docs/man/xl.cfg.pod.5
+++ b/docs/man/xl.cfg.pod.5
@@ -133,6 +133,18 @@ the same time, achieving efficient utili
=back
+=item B<minnodes=N>
+
+Tells libxl to place the new domain on at least `N` nodes. This is only
+effective if automatic NUMA placement occurs (i.e., if no `cpus=` option
+is specified).
+
+=item B<maxnodes=M>
+
+Tells libxl to place the new domain on at most `M` nodes. This is only
+effective if automatic NUMA placement occurs (i.e., if no `cpus=` option
+is specified).
+
=head3 CPU Scheduling
=over 4
diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
--- a/tools/libxl/libxl_create.c
+++ b/tools/libxl/libxl_create.c
@@ -219,6 +219,11 @@ int libxl__domain_build_info_setdefault(
libxl_defbool_setdefault(&b_info->numa_placement, true);
+ if (!b_info->min_nodes)
+ b_info->min_nodes = 0;
+ if (!b_info->max_nodes)
+ b_info->max_nodes = 0;
+
if (b_info->max_memkb == LIBXL_MEMKB_DEFAULT)
b_info->max_memkb = 32 * 1024;
if (b_info->target_memkb == LIBXL_MEMKB_DEFAULT)
diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
--- a/tools/libxl/libxl_dom.c
+++ b/tools/libxl/libxl_dom.c
@@ -174,7 +174,8 @@ static int numa_place_domain(libxl__gc *
/* Find the best candidate with enough free memory and at least
* as much pcpus as the domain has vcpus. */
rc = libxl__get_numa_candidate(gc, memkb, info->max_vcpus,
- 0, 0, &cpupool_info.cpumap,
+ info->min_nodes, info->max_nodes,
+ &cpupool_info.cpumap,
numa_cmpf, &candidate, &found);
if (rc)
goto out;
diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
--- a/tools/libxl/libxl_types.idl
+++ b/tools/libxl/libxl_types.idl
@@ -262,6 +262,8 @@ libxl_domain_build_info = Struct("domain
("avail_vcpus", libxl_bitmap),
("cpumap", libxl_bitmap),
("numa_placement", libxl_defbool),
+ ("min_nodes", integer),
+ ("max_nodes", integer),
("tsc_mode", libxl_tsc_mode),
("max_memkb", MemKB),
("target_memkb", MemKB),
diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c
+++ b/tools/libxl/xl_cmdimpl.c
@@ -731,6 +731,11 @@ static void parse_config_data(const char
libxl_defbool_set(&b_info->numa_placement, false);
}
+ if (!xlu_cfg_get_long (config, "minnodes", &l, 0))
+ b_info->min_nodes = l;
+ if (!xlu_cfg_get_long (config, "maxnodes", &l, 0))
+ b_info->max_nodes = l;
+
if (!xlu_cfg_get_long (config, "memory", &l, 0)) {
b_info->max_memkb = l * 1024;
b_info->target_memkb = b_info->max_memkb;
next prev parent reply other threads:[~2012-10-16 17:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 17:26 [PATCH 0 of 3] Some small NUMA placement improvements Dario Faggioli
2012-10-16 17:26 ` [PATCH 1 of 3] libxl: take node distances into account during NUMA placement Dario Faggioli
2012-10-18 15:17 ` George Dunlap
2012-10-18 23:20 ` Dario Faggioli
2012-10-19 10:03 ` Ian Jackson
2012-10-19 10:39 ` Stefano Stabellini
2012-10-19 10:56 ` Dario Faggioli
2012-10-19 10:35 ` Stefano Stabellini
2012-10-19 10:50 ` George Dunlap
2012-10-19 11:00 ` Dario Faggioli
2012-10-19 14:57 ` Ian Jackson
2012-10-19 18:02 ` Dario Faggioli
2012-10-21 7:35 ` Dario Faggioli
2012-10-16 17:26 ` Dario Faggioli [this message]
2012-10-18 15:21 ` [PATCH 2 of 3] libxl, xl: user can ask for min and max nodes to use during placement George Dunlap
2012-10-16 17:26 ` [PATCH 3 of 3] xl: allow for node-wise specification of vcpu pinning Dario Faggioli
2012-10-18 11:23 ` Ian Campbell
2012-10-18 13:11 ` Dario Faggioli
2012-10-18 13:15 ` Ian Campbell
2012-10-18 13:18 ` Dario Faggioli
2012-10-18 15:30 ` George Dunlap
2012-10-18 22:35 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55f27c485238772388bb.1350408387@Solace \
--to=dario.faggioli@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andre.przywara@amd.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).