From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@citrix.com>
Subject: Re: [PATCH v7 05/28] xen/arm: ITS: Port ITS driver to
 Xen
Date: Mon, 21 Sep 2015 14:08:47 +0100
Message-ID: <5600015F.9080507@citrix.com>
References: <1442581755-2668-1-git-send-email-vijay.kilari@gmail.com>
	<1442581755-2668-6-git-send-email-vijay.kilari@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1442581755-2668-6-git-send-email-vijay.kilari@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: vijay.kilari@gmail.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, stefano.stabellini@citrix.com, tim@xen.org, xen-devel@lists.xen.org
Cc: Prasun.Kapoor@caviumnetworks.com, Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>, manish.jaggi@caviumnetworks.com
List-Id: xen-devel@lists.xenproject.org

On 18/09/15 14:08, vijay.kilari@gmail.com wrote:
> +static void its_lpi_free(struct its_device *dev)
> +{
> +    int lpi;
> +
> +    spin_lock(&lpi_lock);
> +
> +    for ( lpi = dev->event_map.lpi_base;
> +          lpi < (dev->event_map.lpi_base + dev->event_map.nr_lpis);
> +          lpi += IRQS_PER_CHUNK )
> +    {
> +        int chunk = its_lpi_to_chunk(lpi);
> +
> +        if (chunk > lpi_chunks)
> +            its_err("Bad LPI chunk %d\n", chunk);
> +        if ( test_bit(chunk, lpi_bitmap) )
> +            clear_bit(chunk, lpi_bitmap);
> +    }
> +
> +    spin_unlock(&lpi_lock);
> +
> +    xfree(dev->event_map.lpi_map);

You didn't import correctly the patch which support collection for
Linux. It misses:

      xfree(dev->event_map.col_map);

Regards,

-- 
Julien Grall