From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v7 13/28] xen/arm: Move vgic rank locking inside get_irq_priority Date: Mon, 21 Sep 2015 15:49:54 +0100 Message-ID: <56001912.70304@citrix.com> References: <1442581755-2668-1-git-send-email-vijay.kilari@gmail.com> <1442581755-2668-14-git-send-email-vijay.kilari@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1442581755-2668-14-git-send-email-vijay.kilari@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: vijay.kilari@gmail.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, stefano.stabellini@citrix.com, tim@xen.org, xen-devel@lists.xen.org Cc: Prasun.Kapoor@caviumnetworks.com, Vijaya Kumar K , manish.jaggi@caviumnetworks.com List-Id: xen-devel@lists.xenproject.org On 18/09/15 14:09, vijay.kilari@gmail.com wrote: > From: Vijaya Kumar K > > Move vgic rank locking inside get_irq_priority callback. > LPIs does not have vgic rank lock for reading LPI priority. > So make generic vgic code cleaner. The commit message is not clear. I would rewrite like that: "The LPIs will require a different locking scheme to retrieve the priority. So move the vGIC rank locking inside the callback get_irq_priority." > > Signed-off-by: Vijaya Kumar K Assuming that the suggested commit message is fine for you: Reviewed-by: Julien Grall Regards, -- Julien Grall