[PATCH] IOMMU: complete/correct comment explaining "iommu=" sub-options

[PATCH] IOMMU: complete/correct comment explaining "iommu=" sub-options

[Jan Beulich]

[-- Attachment #1: Type: text/plain, Size: 1409 bytes --]

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/drivers/passthrough/iommu.c
+++ b/xen/drivers/passthrough/iommu.c
@@ -31,13 +31,19 @@ static void iommu_dump_p2m_table(unsigne
  *
  *   off|no|false|disable       Disable IOMMU (default)
  *   force|required             Don't boot unless IOMMU is enabled
+ *   no-intremap                Disable interrupt remapping
+ *   verbose                    Be more verbose
+ *   debug                      Enable debugging messages and checks
  *   workaround_bios_bug        Workaround some bios issue to still enable
-                                VT-d, don't guarantee security
+ *                              VT-d, don't guarantee security
  *   dom0-passthrough           No DMA translation at all for Dom0
  *   dom0-strict                No 1:1 memory mapping for Dom0
+ *   no-sharept                 Don't share VT-d and EPT page tables
  *   no-snoop                   Disable VT-d Snoop Control
  *   no-qinval                  Disable VT-d Queued Invalidation
- *   no-intremap                Disable VT-d Interrupt Remapping
+ *   no-igfx                    Disable VT-d for IGD devices (insecure)
+ *   no-amd-iommu-perdev-intremap Don't use per-device interrupt remapping
+ *                              tables (insecure)
  */
 custom_param("iommu", parse_iommu_param);
 bool_t __initdata iommu_enable = 1;




[-- Attachment #2: IOMMU-option-comment.patch --]
[-- Type: text/plain, Size: 1470 bytes --]

IOMMU: complete/correct comment explaining "iommu=" sub-options

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/drivers/passthrough/iommu.c
+++ b/xen/drivers/passthrough/iommu.c
@@ -31,13 +31,19 @@ static void iommu_dump_p2m_table(unsigne
  *
  *   off|no|false|disable       Disable IOMMU (default)
  *   force|required             Don't boot unless IOMMU is enabled
+ *   no-intremap                Disable interrupt remapping
+ *   verbose                    Be more verbose
+ *   debug                      Enable debugging messages and checks
  *   workaround_bios_bug        Workaround some bios issue to still enable
-                                VT-d, don't guarantee security
+ *                              VT-d, don't guarantee security
  *   dom0-passthrough           No DMA translation at all for Dom0
  *   dom0-strict                No 1:1 memory mapping for Dom0
+ *   no-sharept                 Don't share VT-d and EPT page tables
  *   no-snoop                   Disable VT-d Snoop Control
  *   no-qinval                  Disable VT-d Queued Invalidation
- *   no-intremap                Disable VT-d Interrupt Remapping
+ *   no-igfx                    Disable VT-d for IGD devices (insecure)
+ *   no-amd-iommu-perdev-intremap Don't use per-device interrupt remapping
+ *                              tables (insecure)
  */
 custom_param("iommu", parse_iommu_param);
 bool_t __initdata iommu_enable = 1;

[-- Attachment #3: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] IOMMU: complete/correct comment explaining "iommu=" sub-options

[Andrew Cooper]

On 22/09/2015 08:04, Jan Beulich wrote:
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper@citrix.com>

Some of these are overly Intel-specific, but while AMD has no
implementation, this isn't much of a problem.

Re: [PATCH] IOMMU: complete/correct comment explaining "iommu=" sub-options

[Julien Grall]

Hi,

On 22/09/2015 08:15, Andrew Cooper wrote:
> On 22/09/2015 08:04, Jan Beulich wrote:
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> Reviewed-by: Andrew Cooper <andrew.cooper@citrix.com>
>
> Some of these are overly Intel-specific, but while AMD has no
> implementation, this isn't much of a problem.

Note that on ARM, we are only using off|no|false|disable.

We may want to use dom0-strict at some point.

Regards,

-- 
Julien Grall