From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v7 05/28] xen/arm: ITS: Port ITS driver to Xen Date: Tue, 22 Sep 2015 13:34:42 +0100 Message-ID: <56014AE2.2000408@citrix.com> References: <1442581755-2668-1-git-send-email-vijay.kilari@gmail.com> <1442581755-2668-6-git-send-email-vijay.kilari@gmail.com> <55FFE8AD.9060208@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Vijay Kilari Cc: Ian Campbell , Stefano Stabellini , Prasun Kapoor , Vijaya Kumar K , Tim Deegan , "xen-devel@lists.xen.org" , Stefano Stabellini , manish.jaggi@caviumnetworks.com List-Id: xen-devel@lists.xenproject.org On 22/09/15 11:34, Vijay Kilari wrote: > On Mon, Sep 21, 2015 at 4:53 PM, Julien Grall wrote: >> Maybe you want to add the suffix _cmd to everyone to avoid having only >> one because of C spec issue. > > suffixing _cmd will look ugly ( as below ex) where "cmd" is repeated twice. Well, you already have this problem with "int_cmd", the cmd is repeated twice ;). Anyway that was only a suggestion, if it doesn't work for you add a comment to explain, even if it's obvious why the "_cmd" for int. Regards, -- Julien Grall