From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@citrix.com>
Subject: Re: [PATCH v7 16/28] xen/arm: ITS: Add virtual ITS
 commands support
Date: Tue, 22 Sep 2015 14:47:39 +0100
Message-ID: <56015BFB.9070000@citrix.com>
References: <1442581755-2668-1-git-send-email-vijay.kilari@gmail.com>
	<1442581755-2668-17-git-send-email-vijay.kilari@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1442581755-2668-17-git-send-email-vijay.kilari@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: vijay.kilari@gmail.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, stefano.stabellini@citrix.com, tim@xen.org, xen-devel@lists.xen.org
Cc: Prasun.Kapoor@caviumnetworks.com, Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>, manish.jaggi@caviumnetworks.com
List-Id: xen-devel@lists.xenproject.org

Hi Vijay,

On 18/09/15 14:09, vijay.kilari@gmail.com wrote:
> From: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
> 
> Add Virtual ITS command processing support to Virtual ITS driver
> 
> Signed-off-by: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>

I've got minor comments in vits_get_max_collections. With that addressed:

Reviewed-by: Julien Grall <julien.grall@citrix.com>


[...]

> +static inline uint16_t vits_get_max_collections(struct domain *d)
> +{
> +    /*
> +     * ITS only supports up to 256 collections without
> +     * provisioning external memory. As per vITS design, number of
> +     * vCPUS should not exceed max number of collections.
> +     */
> +    ASSERT(d->max_vcpus < 256);
> +
> +    /* Each collection corresponds to one CPU(vCPU). collections are

NIT: The coding style for comment is

/*
 * My comments
 * ...
 */

s/collections are/Collections/

> +     * used to move interrupts from one CPU to another. The ITS
> +     * mandated to implement N + 1 collections where N is the number of

s/mandated/mandates/

> +     * processor on the platform (i.e max number of VCPUs for a given
> +     * guest).

I was about to suggestion mention the section in the spec. Although I'm
not able to find a related section in the Public doc (IHI0069A).

Might still be worth to mention the PRD03-GENC-010745 24 section 4.9.15?

> +     */
> +    return (d->max_vcpus + 1);
> +}

Regards,


-- 
Julien Grall