From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2 for-4.6 0/2] libxl: devd fixes
Date: Wed, 23 Sep 2015 16:10:20 +0200 [thread overview]
Message-ID: <5602B2CC.7010707@citrix.com> (raw)
In-Reply-To: <20150923132000.GA9104@zion.uk.xensource.com>
El 23/09/15 a les 15.20, Wei Liu ha escrit:
> On Wed, Sep 23, 2015 at 12:06:54PM +0200, Roger Pau Monne wrote:
>> The following patches fix an error when reconnecting a device that's handled
>> by a driver domain and a possible race when doing the cleanup of the backend
>> path.
>>
>> I think both should be included in 4.6, since this a regression as compared
>> to using udev inside of the driver domain.
>>
>
> The first paragraph doesn't look specific to "xl devd".
In order to make it clearer I would change it to:
The following patches fix an error when reconnecting a device that's
handled by a driver domain running 'xl devd' and a possible race when
doing the cleanup of the backend path.
> While I agree this should be fixed and the patches are fine, do you have
> idea while udev worked in the first place?
udev never worked fine IMHO, there were races, specially regarding the
disconnection phase, were the toolstack could have removed the backend
xenstore nodes before giving udev a chance to run.
However udev didn't have the problem that this series fixes, which is
that a reconnection of the backend/frontend results in 'xl devd'
assuming the device has been removed and performing the cleanup of the
backend xenstore nodes.
Roger.
next prev parent reply other threads:[~2015-09-23 14:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 10:06 [PATCH v2 for-4.6 0/2] libxl: devd fixes Roger Pau Monne
2015-09-23 10:06 ` [PATCH v2 for-4.6 1/2] libxl: fix devd removal path Roger Pau Monne
2015-09-23 11:08 ` Ian Campbell
2015-09-23 10:06 ` [PATCH v2 for-4.6 2/2] libxl: fix the cleanup of the backend path when using driver domains Roger Pau Monne
2015-09-23 11:09 ` Ian Campbell
2015-09-23 13:20 ` [PATCH v2 for-4.6 0/2] libxl: devd fixes Wei Liu
2015-09-23 14:10 ` Roger Pau Monné [this message]
2015-09-23 15:21 ` Wei Liu
2015-09-24 11:30 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5602B2CC.7010707@citrix.com \
--to=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).