From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>, Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH v2] xen/keyhandler: Rework keyhandler infrastructure
Date: Thu, 24 Sep 2015 11:47:02 +0100 [thread overview]
Message-ID: <5603D4A6.7060106@citrix.com> (raw)
In-Reply-To: <5603EFE502000078000A535C@prv-mh.provo.novell.com>
On 24/09/15 11:43, Jan Beulich wrote:
>>>> On 24.09.15 at 12:36, <andrew.cooper3@citrix.com> wrote:
>>>> +void register_irq_keyhandler(unsigned char key,
>>>> + irq_keyhandler_fn_t *fn,
>>>> + const char *desc,
>>>> + bool_t diagnostic);
>>> I wonder whether the last parameter is really useful here.
>> Yes. There are diagnostic irq_keyhandlers, 'd' for example.
> I know; I was wondering if we would ever reasonably gain ones
> outside of keyhandler.c.
I am not sure, but as I said, it should be present for completeness.
The extra incurred overhead is not an issue.
~Andrew
prev parent reply other threads:[~2015-09-24 10:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 15:55 [PATCH v2] xen/keyhandler: Rework keyhandler infrastructure Andrew Cooper
2015-09-24 10:09 ` Jan Beulich
2015-09-24 10:36 ` Andrew Cooper
2015-09-24 10:43 ` Jan Beulich
2015-09-24 10:47 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5603D4A6.7060106@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).