From mboxrd@z Thu Jan  1 00:00:00 1970
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH] xen: sched: adjustments to some performance
	counters
Date: Fri, 25 Sep 2015 12:19:31 +0200
Message-ID: <56051FB3.2090805@suse.com>
References: <20150925095312.11655.93745.stgit@Solace.station>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <jgross@suse.com>) id 1ZfQ6N-0006g1-Lg
	for xen-devel@lists.xenproject.org; Fri, 25 Sep 2015 10:19:39 +0000
In-Reply-To: <20150925095312.11655.93745.stgit@Solace.station>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Dario Faggioli <dario.faggioli@citrix.com>, xen-devel@lists.xenproject.org
Cc: George Dunlap <george.dunlap@eu.citrix.com>, Meng Xu <mengxu@cis.upenn.edu>, Jan Beulich <jbeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On 09/25/2015 11:53 AM, Dario Faggioli wrote:
> More specifically:
>
> 1) rename vcpu_destroy to vcpu_remove
>
> It seems this have had to be done as part of 7e6b926a
> ("cpupools: Make interface more consistent"), which
> renamed the function but not the counter.
>
> In fact, because of cpupools, vcpus are not only removed
> from a scheduler when they are destroyed, but also when
> domains move between pools.
>
> Make the related statistics counter reflect that more
> properly.
>
> 2) rename vcpu_init to vcpu_alloc
>
> As it lives in *_alloc_vdata.
>
> 3) add vcpu_insert
>
> matching vcpu_remove, and useful to quickly check
> whether the number of insertions and removal matches,
> or in general investigare their relationship.
>
> Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
> ---
> Cc: George Dunlap <george.dunlap@eu.citrix.com>
> Cc: Juergen Gross <jgross@suse.com>
> Cc: Meng Xu <mengxu@cis.upenn.edu>
> Cc: Jan Beulich <jbeulich@suse.com>
> ---
> This would be v2 of "xen: sched: rename vcpu_destroy perf counter to
> vcpu_remove", but both the title and the content changed, so I'm treating it as
> a fresh submission (and not applying the Rev-by Juergen gave to it).

You can have it again:

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen