From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v6 24/29] xen/x86: allow HVM guests to use hypercalls to bring up vCPUs Date: Fri, 25 Sep 2015 16:16:30 +0100 Message-ID: <5605654E.2030502@citrix.com> References: <1441368548-43465-1-git-send-email-roger.pau@citrix.com> <1441368548-43465-25-git-send-email-roger.pau@citrix.com> <5600420C02000078000A4234@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZfUji-0002j2-RU for xen-devel@lists.xenproject.org; Fri, 25 Sep 2015 15:16:34 +0000 In-Reply-To: <5600420C02000078000A4234@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , Roger Pau Monne Cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Ian Campbell List-Id: xen-devel@lists.xenproject.org On 21/09/15 16:44, Jan Beulich wrote: >> + uint32_t cr0; >> + uint32_t cr3; >> + uint32_t cr4; >> + uint64_t efer; > What again was the point of having EFER here? > EFER.NX must match what the BSP chose to set up in the pagetables pointed to in %cr3, or a triple fault will occur. ~Andrew