From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@citrix.com>
Subject: Re: [PATCH 4/8] xen/arm: Warn when a device tree path
 will be re-used by Xen
Date: Mon, 28 Sep 2015 17:05:13 +0100
Message-ID: <56096539.2020808@citrix.com>
References: <1442944062-4324-1-git-send-email-julien.grall@citrix.com>
	<1442944062-4324-5-git-send-email-julien.grall@citrix.com>
	<1443197438.25250.186.camel@citrix.com> <56096054.5000102@citrix.com>
	<1443455702.16718.3.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=7067c2ced=julien.grall@citrix.com>)
	id 1Zgawq-00053f-1b
	for xen-devel@lists.xenproject.org; Mon, 28 Sep 2015 16:06:40 +0000
In-Reply-To: <1443455702.16718.3.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xenproject.org
Cc: stefano.stabellini@citrix.com
List-Id: xen-devel@lists.xenproject.org

On 28/09/15 16:55, Ian Campbell wrote:
> On Mon, 2015-09-28 at 16:44 +0100, Julien Grall wrote:
>>> And that case does indeed seem worth warning about but the commit
>>> message
>>> needs to be clearer about the circumstances of the logging.
>>
>> What about:
>>
>> "Xen is using unconditionally some device tree path to create DOM0
> 
> "unconditionally using" and "paths", and probably s/some/certain/.
> 
> 
>> specific node (for instance /psci, /memory and /hypervisor).
>>
>> Print a warning message on the console to let know user the user if we
> 
> "to let the user know"
> 
>> re-use one of this node.
> 
> "these nodes"
> 
>> Note that the content of most those nodes are very common and they
> 
> "most of those is"
> 
>> should have already been skipped via the compatible string or type
>> string. This warning is here to catch buggy device-tree and compatible
>> string that we may not yet support in Xen."
> 
> I don't think they are "buggy", perhaps more like "unusual".

I will use "unusual".

Regards,

-- 
Julien Grall