From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Malcolm Crossley <malcolm.crossley@citrix.com>
Cc: xen-devel@lists.xenproject.org, David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH] x86/xen: Do not clip xen_e820_map to xen_e820_map_entries when sanitizing map
Date: Mon, 28 Sep 2015 12:56:47 -0400 [thread overview]
Message-ID: <5609714F.7010807@oracle.com> (raw)
In-Reply-To: <1443436612-23361-1-git-send-email-malcolm.crossley@citrix.com>
On 09/28/2015 06:36 AM, Malcolm Crossley wrote:
> Sanitizing the e820 map may produce extra E820 entries which would result in
> the topmost E820 entries being removed. The removed entries would typically
> include the top E820 usable RAM region and thus result in the domain having
> signicantly less RAM available to it.
>
> Fix by allowing sanitize_e820_map to use the full size of the allocated E820
> array.
>
> Signed-off-by: Malcolm Crossley <malcolm.crossley@citrix.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> ---
> arch/x86/xen/setup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c
> index f5ef674..415a55f 100644
> --- a/arch/x86/xen/setup.c
> +++ b/arch/x86/xen/setup.c
> @@ -798,7 +798,7 @@ char * __init xen_memory_setup(void)
> xen_ignore_unusable();
>
> /* Make sure the Xen-supplied memory map is well-ordered. */
> - sanitize_e820_map(xen_e820_map, xen_e820_map_entries,
> + sanitize_e820_map(xen_e820_map, ARRAY_SIZE(xen_e820_map),
> &xen_e820_map_entries);
>
> max_pages = xen_get_max_pages();
next prev parent reply other threads:[~2015-09-28 16:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 10:36 [PATCH] x86/xen: Do not clip xen_e820_map to xen_e820_map_entries when sanitizing map Malcolm Crossley
2015-09-28 16:56 ` Boris Ostrovsky [this message]
2015-09-28 17:04 ` David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5609714F.7010807@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=malcolm.crossley@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).