From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH] x86/xen: Do not clip xen_e820_map to xen_e820_map_entries when sanitizing map Date: Mon, 28 Sep 2015 12:56:47 -0400 Message-ID: <5609714F.7010807@oracle.com> References: <1443436612-23361-1-git-send-email-malcolm.crossley@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zgbkw-0004F3-9m for xen-devel@lists.xenproject.org; Mon, 28 Sep 2015 16:58:26 +0000 In-Reply-To: <1443436612-23361-1-git-send-email-malcolm.crossley@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Malcolm Crossley Cc: xen-devel@lists.xenproject.org, David Vrabel List-Id: xen-devel@lists.xenproject.org On 09/28/2015 06:36 AM, Malcolm Crossley wrote: > Sanitizing the e820 map may produce extra E820 entries which would result in > the topmost E820 entries being removed. The removed entries would typically > include the top E820 usable RAM region and thus result in the domain having > signicantly less RAM available to it. > > Fix by allowing sanitize_e820_map to use the full size of the allocated E820 > array. > > Signed-off-by: Malcolm Crossley Reviewed-by: Boris Ostrovsky > --- > arch/x86/xen/setup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c > index f5ef674..415a55f 100644 > --- a/arch/x86/xen/setup.c > +++ b/arch/x86/xen/setup.c > @@ -798,7 +798,7 @@ char * __init xen_memory_setup(void) > xen_ignore_unusable(); > > /* Make sure the Xen-supplied memory map is well-ordered. */ > - sanitize_e820_map(xen_e820_map, xen_e820_map_entries, > + sanitize_e820_map(xen_e820_map, ARRAY_SIZE(xen_e820_map), > &xen_e820_map_entries); > > max_pages = xen_get_max_pages();