* [PATCH] x86/xen: Do not clip xen_e820_map to xen_e820_map_entries when sanitizing map
@ 2015-09-28 10:36 Malcolm Crossley
2015-09-28 16:56 ` Boris Ostrovsky
2015-09-28 17:04 ` David Vrabel
0 siblings, 2 replies; 3+ messages in thread
From: Malcolm Crossley @ 2015-09-28 10:36 UTC (permalink / raw)
Cc: xen-devel, Malcolm Crossley, David Vrabel, Boris Ostrovsky
Sanitizing the e820 map may produce extra E820 entries which would result in
the topmost E820 entries being removed. The removed entries would typically
include the top E820 usable RAM region and thus result in the domain having
signicantly less RAM available to it.
Fix by allowing sanitize_e820_map to use the full size of the allocated E820
array.
Signed-off-by: Malcolm Crossley <malcolm.crossley@citrix.com>
---
arch/x86/xen/setup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c
index f5ef674..415a55f 100644
--- a/arch/x86/xen/setup.c
+++ b/arch/x86/xen/setup.c
@@ -798,7 +798,7 @@ char * __init xen_memory_setup(void)
xen_ignore_unusable();
/* Make sure the Xen-supplied memory map is well-ordered. */
- sanitize_e820_map(xen_e820_map, xen_e820_map_entries,
+ sanitize_e820_map(xen_e820_map, ARRAY_SIZE(xen_e820_map),
&xen_e820_map_entries);
max_pages = xen_get_max_pages();
--
1.7.12.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/xen: Do not clip xen_e820_map to xen_e820_map_entries when sanitizing map
2015-09-28 10:36 [PATCH] x86/xen: Do not clip xen_e820_map to xen_e820_map_entries when sanitizing map Malcolm Crossley
@ 2015-09-28 16:56 ` Boris Ostrovsky
2015-09-28 17:04 ` David Vrabel
1 sibling, 0 replies; 3+ messages in thread
From: Boris Ostrovsky @ 2015-09-28 16:56 UTC (permalink / raw)
To: Malcolm Crossley; +Cc: xen-devel, David Vrabel
On 09/28/2015 06:36 AM, Malcolm Crossley wrote:
> Sanitizing the e820 map may produce extra E820 entries which would result in
> the topmost E820 entries being removed. The removed entries would typically
> include the top E820 usable RAM region and thus result in the domain having
> signicantly less RAM available to it.
>
> Fix by allowing sanitize_e820_map to use the full size of the allocated E820
> array.
>
> Signed-off-by: Malcolm Crossley <malcolm.crossley@citrix.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> ---
> arch/x86/xen/setup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c
> index f5ef674..415a55f 100644
> --- a/arch/x86/xen/setup.c
> +++ b/arch/x86/xen/setup.c
> @@ -798,7 +798,7 @@ char * __init xen_memory_setup(void)
> xen_ignore_unusable();
>
> /* Make sure the Xen-supplied memory map is well-ordered. */
> - sanitize_e820_map(xen_e820_map, xen_e820_map_entries,
> + sanitize_e820_map(xen_e820_map, ARRAY_SIZE(xen_e820_map),
> &xen_e820_map_entries);
>
> max_pages = xen_get_max_pages();
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/xen: Do not clip xen_e820_map to xen_e820_map_entries when sanitizing map
2015-09-28 10:36 [PATCH] x86/xen: Do not clip xen_e820_map to xen_e820_map_entries when sanitizing map Malcolm Crossley
2015-09-28 16:56 ` Boris Ostrovsky
@ 2015-09-28 17:04 ` David Vrabel
1 sibling, 0 replies; 3+ messages in thread
From: David Vrabel @ 2015-09-28 17:04 UTC (permalink / raw)
To: Malcolm Crossley; +Cc: xen-devel, Boris Ostrovsky, David Vrabel
On 28/09/15 11:36, Malcolm Crossley wrote:
> Sanitizing the e820 map may produce extra E820 entries which would result in
> the topmost E820 entries being removed. The removed entries would typically
> include the top E820 usable RAM region and thus result in the domain having
> signicantly less RAM available to it.
>
> Fix by allowing sanitize_e820_map to use the full size of the allocated E820
> array.
Applied to for-linus-4.3b and tagged for stable, thanks.
David
>
> Signed-off-by: Malcolm Crossley <malcolm.crossley@citrix.com>
> ---
> arch/x86/xen/setup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c
> index f5ef674..415a55f 100644
> --- a/arch/x86/xen/setup.c
> +++ b/arch/x86/xen/setup.c
> @@ -798,7 +798,7 @@ char * __init xen_memory_setup(void)
> xen_ignore_unusable();
>
> /* Make sure the Xen-supplied memory map is well-ordered. */
> - sanitize_e820_map(xen_e820_map, xen_e820_map_entries,
> + sanitize_e820_map(xen_e820_map, ARRAY_SIZE(xen_e820_map),
> &xen_e820_map_entries);
>
> max_pages = xen_get_max_pages();
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-28 17:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-28 10:36 [PATCH] x86/xen: Do not clip xen_e820_map to xen_e820_map_entries when sanitizing map Malcolm Crossley
2015-09-28 16:56 ` Boris Ostrovsky
2015-09-28 17:04 ` David Vrabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).