xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Chao Peng <chao.p.peng@linux.intel.com>, xen-devel@lists.xen.org
Cc: Ian.Jackson@eu.citrix.com, dario.faggioli@citrix.com,
	wei.liu2@citrix.com, Ian.Campbell@citrix.com,
	stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH v2 for Xen 4.6 5/6] docs: make xl-psr.markdown more precise
Date: Tue, 29 Sep 2015 10:27:09 +0100	[thread overview]
Message-ID: <560A596D.7020201@citrix.com> (raw)
In-Reply-To: <1443512995-11853-6-git-send-email-chao.p.peng@linux.intel.com>

On 29/09/15 08:49, Chao Peng wrote:
> Drop the chapter number as it can be confusing when it gets changed in
> the referred document.
>
> Signed-off-by: Chao Peng <chao.p.peng@linux.intel.com>
> Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
> ---
> v2:
> * minor commit message adjustment.
> ---
>  docs/misc/xl-psr.markdown | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/docs/misc/xl-psr.markdown b/docs/misc/xl-psr.markdown
> index 3545912..737f0f7 100644
> --- a/docs/misc/xl-psr.markdown
> +++ b/docs/misc/xl-psr.markdown
> @@ -14,7 +14,7 @@ tracks cache utilization of memory accesses according to the RMID and reports
>  monitored data via a counter register.
>  
>  For more detailed information please refer to Intel SDM chapter
> -"17.14 - Platform Shared Resource Monitoring: Cache Monitoring Technology".
> +"Platform Shared Resource Monitoring: Cache Monitoring Technology".
>  
>  In Xen's implementation, each domain in the system can be assigned a RMID
>  independently, while RMID=0 is reserved for monitoring domains that don't
> @@ -52,7 +52,7 @@ event type to monitor system total/local memory bandwidth. The same RMID can
>  be used to monitor both cache usage and memory bandwidth at the same time.
>  
>  For more detailed information please refer to Intel SDM chapter
> -"17.14 - Platform Shared Resource Monitoring: Cache Monitoring Technology".
> +"Overview of Cache Monitoring Technology and Memory Bandwidth Monitoring".
>  
>  In Xen's implementation, MBM shares the same set of underlying monitoring
>  service with CMT and can be used to monitor memory bandwidth on a per domain
> @@ -92,7 +92,7 @@ For example, assuming a system with 8 portions and 3 domains:
>     access to one quarter each.
>  
>  For more detailed information please refer to Intel SDM chapter
> -"17.15 - Platform Shared Resource Control: Cache Allocation Technology".
> +"Platform Shared Resource Control: Cache Allocation Technology".
>  
>  In Xen's implementation, CBM can be configured with libxl/xl interfaces but
>  COS is maintained in hypervisor only. The cache partition granularity is per
> @@ -130,4 +130,4 @@ Per domain CBM settings can be shown by:
>  ## Reference
>  
>  [1] Intel SDM
> -(http://www.intel.com/content/www/us/en/processors/architectures-software-developer-manuals.html).
> +(http://www.intel.com/content/dam/www/public/us/en/documents/manuals/64-ia-32-architectures-software-developer-system-programming-manual-325384.pdf).

The other two changes look fine, but this change now points to a
specific instance of the SDM, not the most recent version.  I would
leave the link as it previously was.

~Andrew

  reply	other threads:[~2015-09-29  9:27 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-29  7:49 [PATCH v2 for Xen 4.6 0/6] Several PSR fixes in libxl Chao Peng
2015-09-29  7:49 ` [PATCH v2 for Xen 4.6 1/6] tools/libxl: introduce libxl_get_online_socketmap Chao Peng
2015-09-29  9:10   ` Dario Faggioli
2015-09-29  9:22   ` Wei Liu
2015-09-29  7:49 ` [PATCH v2 for Xen 4.6 2/6] tools/libxl: fix socket display error for CMT Chao Peng
2015-09-29  9:06   ` Dario Faggioli
2015-09-29  7:49 ` [PATCH v2 for Xen 4.6 3/6] tools/libxl: return socket id from libxl_psr_cat_get_l3_info Chao Peng
2015-09-29  9:09   ` Dario Faggioli
2015-09-29  9:22   ` Wei Liu
2015-09-29  7:49 ` [PATCH v2 for Xen 4.6 4/6] tools/libxl: fix range check in main_psr_cat_cbm_set Chao Peng
2015-09-29  7:49 ` [PATCH v2 for Xen 4.6 5/6] docs: make xl-psr.markdown more precise Chao Peng
2015-09-29  9:27   ` Andrew Cooper [this message]
2015-09-29  9:55     ` Ian Campbell
2015-09-30  1:34       ` Chao Peng
2015-09-30  8:57         ` Ian Campbell
2015-09-30  9:40           ` Chao Peng
2015-09-29  7:49 ` [PATCH v2 for Xen 4.6 6/6] docs/man: resort sections Chao Peng
2015-09-29  8:53   ` Dario Faggioli
2015-09-29  9:02   ` Wei Liu
2015-09-29  9:33 ` [PATCH v2 for Xen 4.6 0/6] Several PSR fixes in libxl Wei Liu
2015-09-29 10:30   ` Ian Campbell
2015-09-30  1:36     ` Chao Peng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=560A596D.7020201@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=chao.p.peng@linux.intel.com \
    --cc=dario.faggioli@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).