From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 1/2] VT-d: use proper error codes in
	iommu_enable_x2apic_IR()
Date: Tue, 29 Sep 2015 13:27:01 +0100
Message-ID: <560A8395.3030408@citrix.com>
References: <560A92D002000078000A6981@prv-mh.provo.novell.com>
	<560A95DB02000078000A69A9@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=707a9d356=Andrew.Cooper3@citrix.com>)
	id 1Zgu17-0000eB-4a
	for xen-devel@lists.xenproject.org; Tue, 29 Sep 2015 12:28:21 +0000
In-Reply-To: <560A95DB02000078000A69A9@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>
Cc: Yang Z Zhang <yang.z.zhang@intel.com>, Kevin Tian <kevin.tian@intel.com>
List-Id: xen-devel@lists.xenproject.org

On 29/09/15 12:44, Jan Beulich wrote:
> ... allowing to suppress a confusing messeage combination: When
> ACPI_DMAR_X2APIC_OPT_OUT is set, so far we first logged a message
> that IR could not be enabled (hence not using x2APIC), followed by
> one indicating successful initialization of IR (if no other problems
> prevented that).
>
> Also adjust the return type of iommu_supports_eim() and fix some
> broken indentation in the function.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>