From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH] xen: sched: adjustments to some performance counters Date: Tue, 29 Sep 2015 15:24:02 +0100 Message-ID: <560A9F02.20504@citrix.com> References: <20150925095312.11655.93745.stgit@Solace.station> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZgvpA-0004gJ-In for xen-devel@lists.xenproject.org; Tue, 29 Sep 2015 14:24:08 +0000 In-Reply-To: <20150925095312.11655.93745.stgit@Solace.station> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Dario Faggioli , xen-devel@lists.xenproject.org Cc: George Dunlap , Juergen Gross , Meng Xu , Jan Beulich List-Id: xen-devel@lists.xenproject.org On 25/09/15 10:53, Dario Faggioli wrote: > More specifically: > > 1) rename vcpu_destroy to vcpu_remove > > It seems this have had to be done as part of 7e6b926a > ("cpupools: Make interface more consistent"), which > renamed the function but not the counter. > > In fact, because of cpupools, vcpus are not only removed > from a scheduler when they are destroyed, but also when > domains move between pools. > > Make the related statistics counter reflect that more > properly. > > 2) rename vcpu_init to vcpu_alloc > > As it lives in *_alloc_vdata. > > 3) add vcpu_insert > > matching vcpu_remove, and useful to quickly check > whether the number of insertions and removal matches, > or in general investigare their relationship. > > Signed-off-by: Dario Faggioli The changeset summary is a bit vague, but I can't immediately think of a better headline title. Acked-by: George Dunlap