From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] build: drop unused SUBARCH variable Date: Wed, 30 Sep 2015 19:02:23 +0100 Message-ID: <560C23AF.5090604@citrix.com> References: <1442601664-7600-1-git-send-email-cardoe@cardoe.com> <560C22B8.30907@cardoe.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <560C22B8.30907@cardoe.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Doug Goldstein , Ian Campbell , Ian Jackson , Jan Beulich , Keir Fraser , Tim Deegan , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 30/09/15 18:58, Doug Goldstein wrote: > On 9/18/15 1:41 PM, Doug Goldstein wrote: >> This variable appears to be unused throughout the code base. >> >> Signed-off-by: Doug Goldstein >> --- >> Makefile | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/Makefile b/Makefile >> index 75177f0..8a9331f 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -35,8 +35,7 @@ mini-os-dir-force-update: mini-os-dir >> $(GIT) reset --hard $(MINIOS_UPSTREAM_REVISION); \ >> fi >> >> -SUBARCH := $(subst x86_32,i386,$(XEN_TARGET_ARCH)) >> -export XEN_TARGET_ARCH SUBARCH >> +export XEN_TARGET_ARCH >> export DESTDIR >> >> # build and install everything into the standard system directories >> > > ping? Jan tends to not notify when a patch has been committed. It's in the tree since last week: commit 063792541db41167db9467feadb700de64cfcd16 Author: Doug Goldstein Date: Mon Sep 21 16:14:19 2015 +0200 build: drop unused SUBARCH variable This variable appears to be unused throughout the code base. Signed-off-by: Doug Goldstein Regards, -- Julien Grall