From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v1 7/8] xen/arm: vgic: Introduce helpers to read/write/clear/set vGIC register ... Date: Fri, 2 Oct 2015 10:36:45 +0100 Message-ID: <560E502D.7060505@citrix.com> References: <1443192698-16163-1-git-send-email-julien.grall@citrix.com> <1443192698-16163-8-git-send-email-julien.grall@citrix.com> <1443533006.16718.70.camel@citrix.com> <560A96BD.2020902@citrix.com> <1443536651.16718.105.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zhwn8-0008Qb-CX for xen-devel@lists.xenproject.org; Fri, 02 Oct 2015 09:38:14 +0000 In-Reply-To: <1443536651.16718.105.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , xen-devel@lists.xenproject.org Cc: Vijaya.Kumar@caviumnetworks.com, stefano.stabellini@citrix.com, manish.jaggi@caviumnetworks.com, vijay.kilari@gmail.com List-Id: xen-devel@lists.xenproject.org On 29/09/15 15:24, Ian Campbell wrote: > On Tue, 2015-09-29 at 14:48 +0100, Julien Grall wrote: >> On 29/09/15 14:23, Ian Campbell wrote: >>> On Fri, 2015-09-25 at 15:51 +0100, Julien Grall wrote: >>>> and use them in the vGIC emulation. >>>> >>>> The GIC registers may support different access sizes. Rather than >>>> open >>>> coding the access for every registers, provide a set of helpers to >>>> access >>>> them. >>>> >>>> The caller will have to call vgic_regN_* where N is the size of the >>>> emulated registers. >>> >>> These helpers end up as e.g. vgic_regN_read/write, but they don't >>> really >>> read or write anything, they just extract the required bits into a >>> register >>> or update the bits into a variable. >>> >>> Can we think of a better name? encode/decode? >> >> Encode/decode would be the best. I will replace read by decode and write >> by encode. Just to keep track, as discussed IRL, I will finally use extract/update. The former will be used when the guest read the GIC MMIO, the latter when it will write. Regards, -- Julien Grall