From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v7 29/32] libxc/xen: introduce a start info structure for HVMlite guests Date: Mon, 5 Oct 2015 11:36:32 +0100 Message-ID: <561252B0.3020206@citrix.com> References: <1443800943-17668-1-git-send-email-roger.pau@citrix.com> <1443800943-17668-30-git-send-email-roger.pau@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zj38J-0000WT-1x for xen-devel@lists.xenproject.org; Mon, 05 Oct 2015 10:36:39 +0000 In-Reply-To: <1443800943-17668-30-git-send-email-roger.pau@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Roger Pau Monne , xen-devel@lists.xenproject.org Cc: Wei Liu , Ian Jackson , Ian Campbell , Jan Beulich , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org T24gMDIvMTAvMTUgMTY6NDksIFJvZ2VyIFBhdSBNb25uZSB3cm90ZToKPiBUaGlzIHN0cnVjdHVy ZSBjb250YWlucyB0aGUgcGh5c2ljYWwgYWRkcmVzcyBvZiB0aGUgY29tbWFuZCBsaW5lLCBhcyB3 ZWxsIGFzCj4gdGhlIHBoeXNpY2FsIGFkZHJlc3Mgb2YgdGhlIGxpc3Qgb2YgbG9hZGVkIG1vZHVs ZXMuIFRoZSBwaHlzaWNhbCBhZGRyZXNzIG9mCj4gdGhpcyBzdHJ1Y3R1cmUgaXMgcGFzc2VkIHRv IHRoZSBndWVzdCBhdCBib290IHRpbWUgaW4gdGhlICVlYnggcmVnaXN0ZXIuCj4KPiBTaWduZWQt b2ZmLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4KPiBDYzogSWFu IEphY2tzb24gPGlhbi5qYWNrc29uQGV1LmNpdHJpeC5jb20+Cj4gQ2M6IFN0ZWZhbm8gU3RhYmVs bGluaSA8c3RlZmFuby5zdGFiZWxsaW5pQGV1LmNpdHJpeC5jb20+Cj4gQ2M6IElhbiBDYW1wYmVs bCA8aWFuLmNhbXBiZWxsQGNpdHJpeC5jb20+Cj4gQ2M6IFdlaSBMaXUgPHdlaS5saXUyQGNpdHJp eC5jb20+Cj4gQ2M6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KPiBDYzogQW5kcmV3 IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4KPiAtLS0KPiBDaGFuZ2VzIHNpbmNl IHY2Ogo+ICAtIEFkZCBhIGNoZWNrIHRvIG1ha2Ugc3VyZSB0aGUgc3RhcnQgaW5mbyBkYXRhIGlz IHBsYWNlZCBiZWxvdyA0R0IuCj4gIC0gTWFrZSBzdXJlIGJ5dGUgYWRkcmVzc2VzIGFyZSB0cmVh dGVkIGFzIHVpbnRwdHJfdC4KPiAgLSBGaXggc2luZ2xlLWxpbmUgY29tbWVudC4KPgo+IENoYW5n ZXMgc2luY2UgdjU6Cj4gIC0gQ2hhbmdlIHNvbWUgb2YgdGhlIGNhbGN1bGF0aW9ucyBwZXJmb3Jt ZWQgdG8gZ2V0IHRoZSB0b3RhbCBzaXplIG9mIHRoZQo+ICAgIHN0YXJ0X2luZm8gcmVnaW9uLgo+ ICAtIFJlcGxhY2UgdGhlIG1lbnRpb24gb2YgSFZNbGl0ZSBpbiBhIGNvbW1lbnQgd2l0aCBQVkgu Cj4gIC0gRG9uJ3QgdXNlIDY0Yml0IGludGVnZXJzIGluIGh2bV9tb2RsaXN0X2VudHJ5Lgo+IC0t LQo+ICB0b29scy9saWJ4Yy94Y19kb21feDg2LmMgfCA2OCArKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKy0KPiAgeGVuL2luY2x1ZGUvcHVibGljL3hlbi5oIHwg MTcgKysrKysrKysrKysrCj4gIDIgZmlsZXMgY2hhbmdlZCwgODQgaW5zZXJ0aW9ucygrKSwgMSBk ZWxldGlvbigtKQo+Cj4gZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnhjL3hjX2RvbV94ODYuYyBiL3Rv b2xzL2xpYnhjL3hjX2RvbV94ODYuYwo+IGluZGV4IDg1YjgyODguLjIwYTM5YjcgMTAwNjQ0Cj4g LS0tIGEvdG9vbHMvbGlieGMveGNfZG9tX3g4Ni5jCj4gKysrIGIvdG9vbHMvbGlieGMveGNfZG9t X3g4Ni5jCj4gQEAgLTU2MSw3ICs1NjEsNzAgQEAgc3RhdGljIGludCBhbGxvY19tYWdpY19wYWdl c19odm0oc3RydWN0IHhjX2RvbV9pbWFnZSAqZG9tKQo+ICAgICAgeGNfaHZtX3BhcmFtX3NldCh4 Y2gsIGRvbWlkLCBIVk1fUEFSQU1fU0hBUklOR19SSU5HX1BGTiwKPiAgICAgICAgICAgICAgICAg ICAgICAgc3BlY2lhbF9wZm4oU1BFQ0lBTFBBR0VfU0hBUklORykpOwo+ICAKPiAtICAgIGlmICgg ZG9tLT5kZXZpY2VfbW9kZWwgKQo+ICsgICAgaWYgKCAhZG9tLT5kZXZpY2VfbW9kZWwgKQo+ICsg ICAgewo+ICsgICAgICAgIHN0cnVjdCB4Y19kb21fc2VnIHNlZzsKPiArICAgICAgICBzdHJ1Y3Qg aHZtX3N0YXJ0X2luZm8gKnN0YXJ0X2luZm87Cj4gKyAgICAgICAgY2hhciAqY21kbGluZTsKPiAr ICAgICAgICBzdHJ1Y3QgaHZtX21vZGxpc3RfZW50cnkgKm1vZGxpc3Q7Cj4gKyAgICAgICAgdm9p ZCAqc3RhcnRfcGFnZTsKPiArICAgICAgICBzaXplX3QgY21kbGluZV9zaXplID0gMDsKPiArICAg ICAgICBzaXplX3Qgc3RhcnRfaW5mb19zaXplID0gc2l6ZW9mKCpzdGFydF9pbmZvKTsKPiArCj4g KyAgICAgICAgaWYgKCBkb20tPmNtZGxpbmUgKQo+ICsgICAgICAgIHsKPiArICAgICAgICAgICAg Y21kbGluZV9zaXplID0gUk9VTkRVUChzdHJsZW4oZG9tLT5jbWRsaW5lKSArIDEsIDgpOwo+ICsg ICAgICAgICAgICBzdGFydF9pbmZvX3NpemUgKz0gY21kbGluZV9zaXplOwo+ICsKPiArICAgICAg ICB9Cj4gKyAgICAgICAgaWYgKCBkb20tPnJhbWRpc2tfYmxvYiApCj4gKyAgICAgICAgICAgIHN0 YXJ0X2luZm9fc2l6ZSArPSBzaXplb2YoKm1vZGxpc3QpOyAvKiBMaW1pdGVkIHRvIG9uZSBtb2R1 bGUuICovCj4gKwo+ICsgICAgICAgIHJjID0geGNfZG9tX2FsbG9jX3NlZ21lbnQoZG9tLCAmc2Vn LCAiSFZNbGl0ZSBzdGFydCBpbmZvIiwgMCwKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHN0YXJ0X2luZm9fc2l6ZSk7Cj4gKyAgICAgICAgaWYgKCByYyAhPSAwICkKPiArICAg ICAgICB7Cj4gKyAgICAgICAgICAgIERPTVBSSU5URigiVW5hYmxlIHRvIHJlc2VydmUgbWVtb3J5 IGZvciB0aGUgc3RhcnQgaW5mbyIpOwo+ICsgICAgICAgICAgICBnb3RvIG91dDsKPiArICAgICAg ICB9Cj4gKwo+ICsgICAgICAgIHN0YXJ0X3BhZ2UgPSB4Y19tYXBfZm9yZWlnbl9yYW5nZSh4Y2gs IGRvbWlkLCBzdGFydF9pbmZvX3NpemUsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIFBST1RfUkVBRCB8IFBST1RfV1JJVEUsCj4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHNlZy5wZm4pOwo+ICsgICAgICAgIGlmICggc3RhcnRf cGFnZSA9PSBOVUxMICkKPiArICAgICAgICB7Cj4gKyAgICAgICAgICAgIERPTVBSSU5URigiVW5h YmxlIHRvIG1hcCBIVk0gc3RhcnQgaW5mbyBwYWdlIik7Cj4gKyAgICAgICAgICAgIGdvdG8gZXJy b3Jfb3V0Owo+ICsgICAgICAgIH0KPiArCj4gKyAgICAgICAgc3RhcnRfaW5mbyA9IHN0YXJ0X3Bh Z2U7CgpZb3Ugc2hvdWxkIGNsZWFyIHN0YXJ0X2luZm8gaGVyZSBmb3Igc2FuaXR5IHNha2UuICBU aGVyZSBpcyBub3RoaW5nCndoaWNoIHJlcXVpcmVzIHRoZSBtYXBwZWQgbWVtb3J5IHRvIGJlIGNs ZWFyLgoKPiArICAgICAgICBjbWRsaW5lID0gc3RhcnRfcGFnZSArIHNpemVvZigqc3RhcnRfaW5m byk7Cj4gKyAgICAgICAgbW9kbGlzdCA9IHN0YXJ0X3BhZ2UgKyBzaXplb2YoKnN0YXJ0X2luZm8p ICsgY21kbGluZV9zaXplOwo+ICsKPiArICAgICAgICBpZiAoIGRvbS0+Y21kbGluZSApCj4gKyAg ICAgICAgewo+ICsgICAgICAgICAgICBzdHJuY3B5KGNtZGxpbmUsIGRvbS0+Y21kbGluZSwgTUFY X0dVRVNUX0NNRExJTkUpOwo+ICsgICAgICAgICAgICBjbWRsaW5lW01BWF9HVUVTVF9DTURMSU5F IC0gMV0gPSAnXDAnOwo+ICsgICAgICAgICAgICBzdGFydF9pbmZvLT5jbWRsaW5lX3BhZGRyID0g KHNlZy5wZm4gPDwgUEFHRV9TSElGVCkgKwo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICgodWludHB0cl90KWNtZGxpbmUgLSAodWludHB0cl90KXN0YXJ0X2luZm8pOwo+ICsgICAg ICAgIH0KPiArCj4gKyAgICAgICAgaWYgKCBkb20tPnJhbWRpc2tfYmxvYiApCj4gKyAgICAgICAg ewo+ICsgICAgICAgICAgICBtb2RsaXN0WzBdLnBhZGRyID0gZG9tLT5yYW1kaXNrX3NlZy52c3Rh cnQgLSBkb20tPnBhcm1zLnZpcnRfYmFzZTsKPiArICAgICAgICAgICAgbW9kbGlzdFswXS5zaXpl ID0gZG9tLT5yYW1kaXNrX3NlZy52ZW5kIC0gZG9tLT5yYW1kaXNrX3NlZy52c3RhcnQ7Cj4gKyAg ICAgICAgICAgIHN0YXJ0X2luZm8tPm1vZGxpc3RfcGFkZHIgPSAoc2VnLnBmbiA8PCBQQUdFX1NI SUZUKSArCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKCh1aW50cHRyX3QpbW9k bGlzdCAtICh1aW50cHRyX3Qpc3RhcnRfaW5mbyk7Cj4gKyAgICAgICAgICAgIHN0YXJ0X2luZm8t Pm5yX21vZHVsZXMgPSAxOwo+ICsgICAgICAgIH0KPiArCj4gKyAgICAgICAgc3RhcnRfaW5mby0+ bWFnaWMgPSBIVk1fU1RBUlRfTUFHSUNfVkFMVUU7Cj4gKwo+ICsgICAgICAgIG11bm1hcChzdGFy dF9wYWdlLCBzdGFydF9pbmZvX3NpemUpOwo+ICsKPiArICAgICAgICBkb20tPnN0YXJ0X2luZm9f cGZuID0gc2VnLnBmbjsKPiArICAgIH0KPiArICAgIGVsc2UKPiAgICAgIHsKPiAgICAgICAgICAv Kgo+ICAgICAgICAgICAqIEFsbG9jYXRlIGFuZCBjbGVhciBhZGRpdGlvbmFsIGlvcmVxIHNlcnZl ciBwYWdlcy4gVGhlIGRlZmF1bHQKPiBAQCAtOTE1LDYgKzk3OCw5IEBAIHN0YXRpYyBpbnQgdmNw dV9odm0oc3RydWN0IHhjX2RvbV9pbWFnZSAqZG9tKQo+ICAgICAgLyogU2V0IHRoZSBJUC4gKi8K PiAgICAgIGJzcF9jdHguY3B1LnJpcCA9IGRvbS0+cGFybXMucGh5c19lbnRyeTsKPiAgCj4gKyAg ICBpZiAoIGRvbS0+c3RhcnRfaW5mb19wZm4gKQo+ICsgICAgICAgIGJzcF9jdHguY3B1LnJieCA9 IGRvbS0+c3RhcnRfaW5mb19wZm4gPDwgUEFHRV9TSElGVDsKPiArCj4gICAgICAvKiBTZXQgdGhl IGVuZCBkZXNjcmlwdG9yLiAqLwo+ICAgICAgYnNwX2N0eC5lbmRfZC50eXBlY29kZSA9IEhWTV9T QVZFX0NPREUoRU5EKTsKPiAgICAgIGJzcF9jdHguZW5kX2QuaW5zdGFuY2UgPSAwOwo+IGRpZmYg LS1naXQgYS94ZW4vaW5jbHVkZS9wdWJsaWMveGVuLmggYi94ZW4vaW5jbHVkZS9wdWJsaWMveGVu LmgKPiBpbmRleCBmZjU1NDdlLi43MDllMTJjIDEwMDY0NAo+IC0tLSBhL3hlbi9pbmNsdWRlL3B1 YmxpYy94ZW4uaAo+ICsrKyBiL3hlbi9pbmNsdWRlL3B1YmxpYy94ZW4uaAo+IEBAIC03ODQsNiAr Nzg0LDIzIEBAIHN0cnVjdCBzdGFydF9pbmZvIHsKPiAgfTsKPiAgdHlwZWRlZiBzdHJ1Y3Qgc3Rh cnRfaW5mbyBzdGFydF9pbmZvX3Q7Cj4gIAo+ICsvKiBTdGFydCBvZiBkYXkgc3RydWN0dXJlIHBh c3NlZCB0byBQVkggZ3Vlc3RzIGluICVlYnguICovCj4gK3N0cnVjdCBodm1fc3RhcnRfaW5mbyB7 Cj4gKyNkZWZpbmUgSFZNX1NUQVJUX01BR0lDX1ZBTFVFIDB4MzM2ZWM1NzgKPiArICAgIHVpbnQz Ml90IG1hZ2ljOyAgICAgICAgICAgICAvKiBDb250YWlucyB0aGUgbWFnaWMgdmFsdWUgMHgzMzZl YzU3OCAgICAgICAqLwo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC8qICgieEVu MyIgd2l0aCB0aGUgMHg4MCBiaXQgb2YgdGhlICJFIiBzZXQpLiovCj4gKyAgICB1aW50MzJfdCBm bGFnczsgICAgICAgICAgICAgLyogU0lGX3h4eCBmbGFncy4gICAgICAgICAgICAgICAgICAgICAg ICAgICAgKi8KPiArICAgIHVpbnQzMl90IGNtZGxpbmVfcGFkZHI7ICAgICAvKiBQaHlzaWNhbCBh ZGRyZXNzIG9mIHRoZSBjb21tYW5kIGxpbmUuICAgICAqLwo+ICsgICAgdWludDMyX3QgbnJfbW9k dWxlczsgICAgICAgIC8qIE51bWJlciBvZiBtb2R1bGVzIHBhc3NlZCB0byB0aGUga2VybmVsLiAg ICovCj4gKyAgICB1aW50MzJfdCBtb2RsaXN0X3BhZGRyOyAgICAgLyogUGh5c2ljYWwgYWRkcmVz cyBvZiBhbiBhcnJheSBvZiAgICAgICAgICAgKi8KPiArICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAvKiBodm1fbW9kbGlzdF9lbnRyeS4gICAgICAgICAgICAgICAgICAgICAgICAqLwoK V2Ugc2hvdWxkIHN0YXRlIHRoYXQgbm90aGluZyB3aWxsIGJlIGxvYWRlZCBhdCAwLCBzbyBhIHBh ZGRyIG9mIDAgbWVhbnMKIm5vdCBwcmVzZW50Ii4KCk90aGVyd2lzZSwKClJldmlld2VkLWJ5OiBB bmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApY ZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK