From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@citrix.com>
Subject: Re: [PATCH for-4.6] xen/public: arm: Use __typeof__
 rather than typeof
Date: Tue, 6 Oct 2015 10:43:23 +0100
Message-ID: <561397BB.5010608@citrix.com>
References: <1443986642-24392-1-git-send-email-julien.grall@citrix.com>
	<20151005134039.GA32145@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=71402f88a=julien.grall@citrix.com>)
	id 1ZjOmO-0000pD-PR
	for xen-devel@lists.xenproject.org; Tue, 06 Oct 2015 09:43:28 +0000
In-Reply-To: <20151005134039.GA32145@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: Keir Fraser <keir@xen.org>, ian.campbell@citrix.com, Tim Deegan <tim@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>, Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org



On 05/10/2015 14:40, Wei Liu wrote:
> On Sun, Oct 04, 2015 at 08:24:02PM +0100, Julien Grall wrote:
>> The keyword typeof is not portable:
>>
>> /usr/src/freebsd/sys/xen/hypervisor.h:93:2: error: implicit declaration
>> of function 'typeof' is invalid in C99
>> [-Werror,-Wimplicit-function-declaration]
>>
>> Signed-off-by: Julien Grall <julien.grall@citrix.com>
>>
>> ---
>> Cc: Ian Campbell <ian.campbell@citrix.com>
>> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
>> Cc: Jan Beulich <jbeulich@suse.com>
>> Cc: Keir Fraser <keir@xen.org>
>> Cc: Tim Deegan <tim@xen.org>
>>
>>      This patch is a candidate to backport in Xen 4.6, 4.5 and 4.4.
>>
>>      It would be nice to get this small fix before Xen 4.6 is released.
>>      Without it, it's not possible to build ARM software including Xen
>>      headers with -std=c99.
>
> This patch doesn't fundamentally make the header ISO compliance.

I never said it was fully ISO compliant. It's just enough to build the 
kernel using -std=c99 with Xen headers.

Although I believe this is the only non-ISO code we have within this header.

> And it's a bit too late for 4.6 now.

It will be for Xen 4.6.1 then.

Regards,

-- 
Julien Grall