From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH XEN v3 02/22] tools: Refactor "xentoollog"
 into its own library
Date: Wed, 7 Oct 2015 15:42:16 +0100
Message-ID: <56152F48.5040403@citrix.com>
References: <1444226543.1410.53.camel@citrix.com>
	<1444227341-875-2-git-send-email-ian.campbell@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1444227341-875-2-git-send-email-ian.campbell@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>, ian.jackson@eu.citrix.com, wei.liu2@citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 07/10/15 15:15, Ian Campbell wrote:
> diff --git a/tools/libs/toollog/Makefile b/tools/libs/toollog/Makefile
> new file mode 100644
> index 0000000..bd12403
> --- /dev/null
> +++ b/tools/libs/toollog/Makefile
> @@ -0,0 +1,59 @@
> +XEN_ROOT = $(CURDIR)/../../..
> +include $(XEN_ROOT)/tools/Rules.mk
> +
> +MAJOR	= 1
> +MINOR	= 0
> +SHLIB_LDFLAGS += -Wl,--version-script=libxentoollog.map
> +
> +CFLAGS	+= -Werror -Wmissing-prototypes
> +CFLAGS	+= -I./include
> +
> +SRCS-y	+= xtl_core.c
> +SRCS-y	+= xtl_logger_stdio.c
> +
> +LIB_OBJS := $(patsubst %.c,%.o,$(SRCS-y))
> +PIC_OBJS := $(patsubst %.c,%.opic,$(SRCS-y))
> +
> +LIB := libxentoollog.a
> +ifneq ($(nosharedlibs),y)
> +LIB += libxentoollog.so
> +endif
> +
> +.PHONY: all
> +all: build
> +
> +.PHONY: build
> +build:
> +	$(MAKE) libs
> +
> +.PHONY: libs
> +libs: $(LIB)
> +
> +libxentoollog.a: $(LIB_OBJS)
> +	$(AR) rc $@ $^
> +
> +libxentoollog.so: libxentoollog.so.$(MAJOR)
> +	$(SYMLINK_SHLIB) $< $@
> +libxentoollog.so.$(MAJOR): libxentoollog.so.$(MAJOR).$(MINOR)
> +	$(SYMLINK_SHLIB) $< $@
> +
> +libxentoollog.so.$(MAJOR).$(MINOR): $(PIC_OBJS) libxentoollog.map
> +	$(CC) $(LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxentoollog.so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $(PIC_OBJS) $(APPEND_LDFLAGS)
> +
> +.PHONY: install
> +install: build
> +	$(INSTALL_DIR) $(DESTDIR)$(libdir)
> +	$(INSTALL_DIR) $(DESTDIR)$(includedir)
> +	$(INSTALL_SHLIB) libxentoollog.so.$(MAJOR).$(MINOR) $(DESTDIR)$(libdir)
> +	$(INSTALL_DATA) libxentoollog.a $(DESTDIR)$(libdir)
> +	$(SYMLINK_SHLIB) libxentoollog.so.$(MAJOR).$(MINOR) $(DESTDIR)$(libdir)/libxentoollog.so.$(MAJOR)
> +	$(SYMLINK_SHLIB) libxentoollog.so.$(MAJOR) $(DESTDIR)$(libdir)/libxentoollog.so

Installation of all .so's needs to be conditional on $(nosharedlibs) to
match the condition in the build rule.

~Andrew