xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	George Dunlap <george.dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v7 12/32] xen/x86: add bitmap of enabled emulated devices
Date: Thu, 8 Oct 2015 12:35:03 +0200	[thread overview]
Message-ID: <561646D7.2090002@citrix.com> (raw)
In-Reply-To: <5616605902000078000A93E8@prv-mh.provo.novell.com>

El 08/10/15 a les 12.23, Jan Beulich ha escrit:
>>>> On 02.10.15 at 17:48, <roger.pau@citrix.com> wrote:
>> @@ -517,6 +520,22 @@ int arch_domain_create(struct domain *d, unsigned int domcr_flags,
>>                 d->domain_id);
>>      }
>>  
>> +    if ( (config->emulation_flags & ~XEN_X86_EMU_ALL) != 0 )
>> +    {
>> +        printk(XENLOG_G_ERR "d%d: Invalid emulation bitmap: %#x\n",
>> +               d->domain_id, config->emulation_flags);
>> +        return -EINVAL;
>> +    }
>> +    if ( (is_hvm_domain(d) && config->emulation_flags != XEN_X86_EMU_ALL) ||
>> +         (is_pv_domain(d) && config->emulation_flags != 0) )
> 
> How about PVH? At this point of the series I'm sure it also needs all flags
> clear? In which case this should become
> 
>     if ( is_hvm_domain(d) ? (config->emulation_flags != XEN_X86_EMU_ALL)
>                           : (config->emulation_flags != 0) )

Right, PVH domains return false for both is_hvm_domain and is_pv_domain.

Roger.

  reply	other threads:[~2015-10-08 10:35 UTC|newest]

Thread overview: 105+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-02 15:48 [PATCH v7 00/32] Introduce HVM without dm and new boot ABI Roger Pau Monne
2015-10-02 15:48 ` [PATCH v7 01/32] xen/vcpu: add missing dummy_vcpu_info to compat VCPUOP_initialise Roger Pau Monne
2015-10-02 18:21   ` Andrew Cooper
2015-10-05 10:05   ` Jan Beulich
2015-10-05 16:18     ` Roger Pau Monné
2015-10-02 15:48 ` [PATCH v7 02/32] libxc: split x86 HVM setup_guest into smaller logical functions Roger Pau Monne
2015-10-02 15:48 ` [PATCH v7 03/32] libxc: unify xc_dom_p2m_{host/guest} Roger Pau Monne
2015-10-02 15:48 ` [PATCH v7 04/32] libxc: introduce the notion of a container type Roger Pau Monne
2015-10-02 15:48 ` [PATCH v7 05/32] libxc: introduce a domain loader for HVM guest firmware Roger Pau Monne
2015-10-07 16:55   ` [PATCH v8 " Roger Pau Monne
2015-10-08  9:22     ` Ian Campbell
2015-10-08  9:26       ` Roger Pau Monné
2015-10-08 10:12     ` Ian Campbell
2015-10-08 10:43       ` Roger Pau Monné
2015-10-08 11:04         ` Ian Campbell
2015-10-08 11:12           ` Andrew Cooper
2015-10-08 11:13           ` Wei Liu
2015-10-02 15:48 ` [PATCH v7 06/32] libxc: make arch_setup_meminit a xc_dom_arch hook Roger Pau Monne
2015-10-02 15:48 ` [PATCH v7 07/32] libxc: make arch_setup_boot{init/late} xc_dom_arch hooks Roger Pau Monne
2015-10-02 15:48 ` [PATCH v7 08/32] libxc: rework BSP initialization Roger Pau Monne
2015-10-02 15:48 ` [PATCH v7 09/32] libxc: introduce a xc_dom_arch for hvm-3.0-x86_32 guests Roger Pau Monne
2015-10-02 15:48 ` [PATCH v7 10/32] libxl: switch HVM domain building to use xc_dom_* helpers Roger Pau Monne
2015-10-02 15:48 ` [PATCH v7 11/32] libxc: remove dead HVM building code Roger Pau Monne
2015-10-02 15:48 ` [PATCH v7 12/32] xen/x86: add bitmap of enabled emulated devices Roger Pau Monne
2015-10-05  9:34   ` Andrew Cooper
2015-10-05 16:40     ` Roger Pau Monné
2015-10-05 16:43       ` Andrew Cooper
2015-10-06 11:05     ` George Dunlap
2015-10-07 11:55       ` Roger Pau Monné
2015-10-07 12:15         ` Jan Beulich
2015-10-07 13:32         ` George Dunlap
2015-10-07 14:01           ` Andrew Cooper
2015-10-08  9:13             ` Roger Pau Monné
2015-10-08 10:23   ` Jan Beulich
2015-10-08 10:35     ` Roger Pau Monné [this message]
2015-10-15  1:48   ` Boris Ostrovsky
2015-10-15  7:34     ` Jan Beulich
2015-10-30 12:00     ` Roger Pau Monné
2015-10-02 15:48 ` [PATCH v7 13/32] xen/vlapic: fixes for HVM code when running without a vlapic Roger Pau Monne
2015-10-02 18:23   ` Andrew Cooper
2015-10-05 10:14     ` Jan Beulich
2015-10-02 20:33   ` Boris Ostrovsky
2015-10-08 10:36   ` Jan Beulich
2015-10-02 15:48 ` [PATCH v7 14/32] xen/x86: allow disabling the emulated local apic Roger Pau Monne
2015-10-05  9:41   ` Andrew Cooper
2015-10-14 14:33   ` Jan Beulich
2015-10-02 15:48 ` [PATCH v7 15/32] xen/x86: allow disabling the emulated HPET Roger Pau Monne
2015-10-02 15:48 ` [PATCH v7 16/32] xen/x86: allow disabling the pmtimer Roger Pau Monne
2015-10-05  9:42   ` Andrew Cooper
2015-10-14 14:37   ` Jan Beulich
2015-10-30 12:50     ` Roger Pau Monné
2015-10-30 13:16       ` Jan Beulich
2015-10-30 15:36         ` Andrew Cooper
2015-11-03  7:21           ` Jan Beulich
2015-11-03 10:57             ` Andrew Cooper
2015-11-03 12:41               ` Jan Beulich
2015-11-04 16:05                 ` Roger Pau Monné
2015-11-04 16:17                   ` Jan Beulich
2015-11-05 14:13                     ` Andrew Cooper
2015-11-05 14:12                 ` Andrew Cooper
2015-10-02 15:48 ` [PATCH v7 17/32] xen/x86: allow disabling the emulated RTC Roger Pau Monne
2015-10-02 15:48 ` [PATCH v7 18/32] xen/x86: allow disabling the emulated IO APIC Roger Pau Monne
2015-10-02 15:48 ` [PATCH v7 19/32] xen/x86: allow disabling the emulated PIC Roger Pau Monne
2015-10-02 15:48 ` [PATCH v7 20/32] xen/x86: set the vPMU interface based on the presence of a lapic Roger Pau Monne
2015-10-14 14:41   ` Jan Beulich
2015-10-14 14:59     ` Boris Ostrovsky
2015-10-14 15:06       ` Roger Pau Monné
2015-10-14 15:10         ` Boris Ostrovsky
2015-10-02 15:48 ` [PATCH v7 21/32] xen/x86: allow disabling the emulated VGA Roger Pau Monne
2015-10-02 15:48 ` [PATCH v7 22/32] xen/x86: allow disabling the emulated IOMMU Roger Pau Monne
2015-10-02 15:48 ` [PATCH v7 23/32] xen/x86: make sure the HVM callback vector is correctly set Roger Pau Monne
2015-10-02 18:37   ` Andrew Cooper
2015-10-05 16:44     ` Roger Pau Monné
2015-10-14 15:54   ` Jan Beulich
2015-10-14 16:01     ` Andrew Cooper
2015-10-15 11:30       ` Paul Durrant
2015-10-30 15:34         ` Roger Pau Monné
2015-10-30 15:38           ` Andrew Cooper
2015-10-02 15:48 ` [PATCH v7 24/32] xen/x86: allow disabling all emulated devices inside of Xen Roger Pau Monne
2015-10-19 14:23   ` Jan Beulich
2015-10-30 16:20     ` Roger Pau Monné
2015-10-30 16:27       ` Jan Beulich
2015-10-02 15:48 ` [PATCH v7 25/32] elfnotes: intorduce a new PHYS_ENTRY elfnote Roger Pau Monne
2015-10-02 15:48 ` [PATCH v7 26/32] libxc: allow creating domains without emulated devices Roger Pau Monne
2015-10-02 15:48 ` [PATCH v7 27/32] xen/x86: allow HVM guests to use hypercalls to bring up vCPUs Roger Pau Monne
2015-10-05 10:28   ` Andrew Cooper
2015-10-08 13:35     ` Roger Pau Monné
2015-10-08 15:21       ` Jan Beulich
2015-10-08 15:33         ` Andrew Cooper
2015-10-19 15:48   ` Jan Beulich
2015-11-05 12:06     ` Roger Pau Monné
2015-10-02 15:48 ` [PATCH v7 28/32] xenconsole: try to attach to PV console if HVM fails Roger Pau Monne
2015-10-02 15:49 ` [PATCH v7 29/32] libxc/xen: introduce a start info structure for HVMlite guests Roger Pau Monne
2015-10-05 10:36   ` Andrew Cooper
2015-10-05 16:47     ` Roger Pau Monné
2015-10-06  9:26   ` Wei Liu
2015-10-02 15:49 ` [PATCH v7 30/32] libxc: switch xc_dom_elfloader to be used with HVMlite domains Roger Pau Monne
2015-10-02 15:49 ` [PATCH v7 31/32] libxl: allow the creation of HVM domains without a device model Roger Pau Monne
2015-10-08 14:36   ` Ian Campbell
2015-10-08 16:27     ` Roger Pau Monné
2015-10-08 16:39       ` Ian Campbell
2015-10-02 15:49 ` [PATCH v7 32/32] libxl: add support for migrating HVM guests " Roger Pau Monne
2015-10-02 18:56   ` Andrew Cooper
2015-10-08 16:10     ` Roger Pau Monné
2015-10-08 11:46 ` [PATCH v7 00/32] Introduce HVM without dm and new boot ABI Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=561646D7.2090002@citrix.com \
    --to=roger.pau@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).