From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhigang Wang Subject: Re: [PATCH] tools/python: remove broken xl binding Date: Thu, 08 Oct 2015 12:10:51 -0400 Message-ID: <5616958B.6060308@oracle.com> References: <1444150646-7959-1-git-send-email-wei.liu2@citrix.com> <56140120.1090904@citrix.com> <20151006190922.GB13546@l.oracle.com> <1444315213.1410.212.camel@citrix.com> <5616848D.9030605@oracle.com> <1444318128.1410.244.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZkDmU-0006kZ-GU for xen-devel@lists.xenproject.org; Thu, 08 Oct 2015 16:10:58 +0000 In-Reply-To: <1444318128.1410.244.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Konrad Rzeszutek Wilk Cc: Andrew Cooper , Wei Liu , Ian Jackson , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On 10/08/2015 11:28 AM, Ian Campbell wrote: > On Thu, 2015-10-08 at 10:58 -0400, Zhigang Wang wrote: >> On 10/08/2015 10:40 AM, Ian Campbell wrote: >>> On Tue, 2015-10-06 at 15:09 -0400, Konrad Rzeszutek Wilk wrote: >>>> On Tue, Oct 06, 2015 at 06:13:04PM +0100, Andrew Cooper wrote: >>>>> On 06/10/15 17:57, Wei Liu wrote: >>>>>> Various people say this binding doesn't compile or doesn't work. >>>>>> Remove >>>>>> it for the benefit of xl feature development -- so that new >>>>>> features >>>>>> won't need to worry about making this broken binding happy. >>>>>> >>>>>> This isn't going to expose any user visible changes because that >>>>>> module >>>>>> is not built by default. >>>>>> >>>>>> Signed-off-by: Wei Liu >>>>> >>>>> Reviewed-by: Andrew Cooper >>>> >>>> And Zhigang mentioned to me offline that he is OK with these being >>>> gone too. >>> >>> Could we get a formal ack from one of you then please? >> >> I'm OK with removing libxl python bindings. > > Thanks, are you okay with me translating this into > > Acked-by: Zhigang Wang > > in the final commit? Yes. Acked-by: Zhigang Wang Thanks, Zhigang