From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Subject: Re: [PATCH v7 31/32] libxl: allow the creation of HVM domains without a device model. Date: Thu, 8 Oct 2015 18:27:21 +0200 Message-ID: <56169969.8090104@citrix.com> References: <1443800943-17668-1-git-send-email-roger.pau@citrix.com> <1443800943-17668-32-git-send-email-roger.pau@citrix.com> <1444314996.1410.210.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZkE2a-0008Cx-8R for xen-devel@lists.xenproject.org; Thu, 08 Oct 2015 16:27:36 +0000 In-Reply-To: <1444314996.1410.210.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , xen-devel@lists.xenproject.org Cc: Wei Liu , Ian Jackson , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org El 08/10/15 a les 16.36, Ian Campbell ha escrit: > On Fri, 2015-10-02 at 17:49 +0200, Roger Pau Monne wrote: >> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl >> index d6ef9a2..082fed8 100644 >> --- a/tools/libxl/libxl_types.idl >> +++ b/tools/libxl/libxl_types.idl >> @@ -98,6 +98,7 @@ libxl_device_model_version = Enumeration("device_model_version", [ >> (0, "UNKNOWN"), >> (1, "QEMU_XEN_TRADITIONAL"), # Historical qemu-xen device model (qemu-dm) >> (2, "QEMU_XEN"), # Upstream based qemu-xen device model >> + (3, "NONE"), # No device model > > Is there a #define LIBXL_HAVE_ somewhere in this series somewhere? > (Not in this patch I think) No, but I'm afraid there should be one indeed. Does: #define LIBXL_HAVE_HVM_WITHOUT_DM 1 Look reasonable? Roger.