* [PATCH] build: drop unused SUBARCH variable
@ 2015-09-18 18:41 Doug Goldstein
2015-09-30 17:58 ` Doug Goldstein
0 siblings, 1 reply; 7+ messages in thread
From: Doug Goldstein @ 2015-09-18 18:41 UTC (permalink / raw)
To: Ian Campbell, Ian Jackson, Jan Beulich, Keir Fraser, Tim Deegan,
xen-devel
Cc: Doug Goldstein
This variable appears to be unused throughout the code base.
Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
---
Makefile | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 75177f0..8a9331f 100644
--- a/Makefile
+++ b/Makefile
@@ -35,8 +35,7 @@ mini-os-dir-force-update: mini-os-dir
$(GIT) reset --hard $(MINIOS_UPSTREAM_REVISION); \
fi
-SUBARCH := $(subst x86_32,i386,$(XEN_TARGET_ARCH))
-export XEN_TARGET_ARCH SUBARCH
+export XEN_TARGET_ARCH
export DESTDIR
# build and install everything into the standard system directories
--
2.4.6
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] build: drop unused SUBARCH variable
2015-09-18 18:41 [PATCH] build: drop unused SUBARCH variable Doug Goldstein
@ 2015-09-30 17:58 ` Doug Goldstein
2015-09-30 18:02 ` Julien Grall
2015-10-01 6:44 ` Jan Beulich
0 siblings, 2 replies; 7+ messages in thread
From: Doug Goldstein @ 2015-09-30 17:58 UTC (permalink / raw)
To: Ian Campbell, Ian Jackson, Jan Beulich, Keir Fraser, Tim Deegan,
xen-devel
[-- Attachment #1.1: Type: text/plain, Size: 732 bytes --]
On 9/18/15 1:41 PM, Doug Goldstein wrote:
> This variable appears to be unused throughout the code base.
>
> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
> ---
> Makefile | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 75177f0..8a9331f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -35,8 +35,7 @@ mini-os-dir-force-update: mini-os-dir
> $(GIT) reset --hard $(MINIOS_UPSTREAM_REVISION); \
> fi
>
> -SUBARCH := $(subst x86_32,i386,$(XEN_TARGET_ARCH))
> -export XEN_TARGET_ARCH SUBARCH
> +export XEN_TARGET_ARCH
> export DESTDIR
>
> # build and install everything into the standard system directories
>
ping?
--
Doug Goldstein
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] build: drop unused SUBARCH variable
2015-09-30 17:58 ` Doug Goldstein
@ 2015-09-30 18:02 ` Julien Grall
2015-10-05 13:37 ` Ian Jackson
2015-10-01 6:44 ` Jan Beulich
1 sibling, 1 reply; 7+ messages in thread
From: Julien Grall @ 2015-09-30 18:02 UTC (permalink / raw)
To: Doug Goldstein, Ian Campbell, Ian Jackson, Jan Beulich,
Keir Fraser, Tim Deegan, xen-devel
On 30/09/15 18:58, Doug Goldstein wrote:
> On 9/18/15 1:41 PM, Doug Goldstein wrote:
>> This variable appears to be unused throughout the code base.
>>
>> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
>> ---
>> Makefile | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index 75177f0..8a9331f 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -35,8 +35,7 @@ mini-os-dir-force-update: mini-os-dir
>> $(GIT) reset --hard $(MINIOS_UPSTREAM_REVISION); \
>> fi
>>
>> -SUBARCH := $(subst x86_32,i386,$(XEN_TARGET_ARCH))
>> -export XEN_TARGET_ARCH SUBARCH
>> +export XEN_TARGET_ARCH
>> export DESTDIR
>>
>> # build and install everything into the standard system directories
>>
>
> ping?
Jan tends to not notify when a patch has been committed. It's in the
tree since last week:
commit 063792541db41167db9467feadb700de64cfcd16
Author: Doug Goldstein <cardoe@cardoe.com>
Date: Mon Sep 21 16:14:19 2015 +0200
build: drop unused SUBARCH variable
This variable appears to be unused throughout the code base.
Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
Regards,
--
Julien Grall
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] build: drop unused SUBARCH variable
2015-09-30 18:02 ` Julien Grall
@ 2015-10-05 13:37 ` Ian Jackson
2015-10-08 18:55 ` Julien Grall
0 siblings, 1 reply; 7+ messages in thread
From: Ian Jackson @ 2015-10-05 13:37 UTC (permalink / raw)
To: Julien Grall
Cc: Keir Fraser, Ian Campbell, Tim Deegan, Doug Goldstein, xen-devel,
Jan Beulich
Julien Grall writes ("Re: [Xen-devel] [PATCH] build: drop unused SUBARCH variable"):
> Jan tends to not notify when a patch has been committed. It's in the
> tree since last week:
>
> commit 063792541db41167db9467feadb700de64cfcd16
> Author: Doug Goldstein <cardoe@cardoe.com>
> Date: Mon Sep 21 16:14:19 2015 +0200
>
> build: drop unused SUBARCH variable
>
> This variable appears to be unused throughout the code base.
>
> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
I wonder if we should have a robot notify the patch From: line when a
patch gets committed.
Ian.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] build: drop unused SUBARCH variable
2015-10-05 13:37 ` Ian Jackson
@ 2015-10-08 18:55 ` Julien Grall
0 siblings, 0 replies; 7+ messages in thread
From: Julien Grall @ 2015-10-08 18:55 UTC (permalink / raw)
To: Ian Jackson
Cc: Keir Fraser, Ian Campbell, Doug Goldstein, Tim Deegan, xen-devel,
Jan Beulich
On 05/10/15 14:37, Ian Jackson wrote:
> Julien Grall writes ("Re: [Xen-devel] [PATCH] build: drop unused SUBARCH variable"):
>> Jan tends to not notify when a patch has been committed. It's in the
>> tree since last week:
>>
>> commit 063792541db41167db9467feadb700de64cfcd16
>> Author: Doug Goldstein <cardoe@cardoe.com>
>> Date: Mon Sep 21 16:14:19 2015 +0200
>>
>> build: drop unused SUBARCH variable
>>
>> This variable appears to be unused throughout the code base.
>>
>> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
>
> I wonder if we should have a robot notify the patch From: line when a
> patch gets committed.
That might be a good idea.
Regards,
--
Julien Grall
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] build: drop unused SUBARCH variable
2015-09-30 17:58 ` Doug Goldstein
2015-09-30 18:02 ` Julien Grall
@ 2015-10-01 6:44 ` Jan Beulich
2015-10-01 8:55 ` Ian Campbell
1 sibling, 1 reply; 7+ messages in thread
From: Jan Beulich @ 2015-10-01 6:44 UTC (permalink / raw)
To: Doug Goldstein
Cc: Keir Fraser, Tim Deegan, Ian Jackson, Ian Campbell, xen-devel
>>> On 30.09.15 at 19:58, <cardoe@cardoe.com> wrote:
> On 9/18/15 1:41 PM, Doug Goldstein wrote:
>> This variable appears to be unused throughout the code base.
>>
>> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
>> ---
>> Makefile | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index 75177f0..8a9331f 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -35,8 +35,7 @@ mini-os-dir-force-update: mini-os-dir
>> $(GIT) reset --hard $(MINIOS_UPSTREAM_REVISION); \
>> fi
>>
>> -SUBARCH := $(subst x86_32,i386,$(XEN_TARGET_ARCH))
>> -export XEN_TARGET_ARCH SUBARCH
>> +export XEN_TARGET_ARCH
>> export DESTDIR
>>
>> # build and install everything into the standard system directories
>>
>
> ping?
This was applied over a week ago. Did you check the tree before
pinging?
Jan
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] build: drop unused SUBARCH variable
2015-10-01 6:44 ` Jan Beulich
@ 2015-10-01 8:55 ` Ian Campbell
0 siblings, 0 replies; 7+ messages in thread
From: Ian Campbell @ 2015-10-01 8:55 UTC (permalink / raw)
To: Jan Beulich, Doug Goldstein
Cc: Keir Fraser, Tim Deegan, Ian Jackson, xen-devel
On Thu, 2015-10-01 at 00:44 -0600, Jan Beulich wrote:
> > > > On 30.09.15 at 19:58, <cardoe@cardoe.com> wrote:
> > On 9/18/15 1:41 PM, Doug Goldstein wrote:
> > > This variable appears to be unused throughout the code base.
> > >
> > > Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
> > > ---
> > > Makefile | 3 +--
> > > 1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > diff --git a/Makefile b/Makefile
> > > index 75177f0..8a9331f 100644
> > > --- a/Makefile
> > > +++ b/Makefile
> > > @@ -35,8 +35,7 @@ mini-os-dir-force-update: mini-os-dir
> > > $(GIT) reset --hard $(MINIOS_UPSTREAM_REVISION); \
> > > fi
> > >
> > > -SUBARCH := $(subst x86_32,i386,$(XEN_TARGET_ARCH))
> > > -export XEN_TARGET_ARCH SUBARCH
> > > +export XEN_TARGET_ARCH
> > > export DESTDIR
> > >
> > > # build and install everything into the standard system directories
> > >
> >
> > ping?
>
> This was applied over a week ago. Did you check the tree before
> pinging?
I've updated http://wiki.xen.org/wiki/Submitting_Xen_Project_Patches to
mention that people should check staging.
Ian.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-10-08 18:55 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-18 18:41 [PATCH] build: drop unused SUBARCH variable Doug Goldstein
2015-09-30 17:58 ` Doug Goldstein
2015-09-30 18:02 ` Julien Grall
2015-10-05 13:37 ` Ian Jackson
2015-10-08 18:55 ` Julien Grall
2015-10-01 6:44 ` Jan Beulich
2015-10-01 8:55 ` Ian Campbell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).