Re: [PATCH v1 4/4] libxl: info: Display build_id of the hypervisor.

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 09/10/15 14:06, Ian Campbell wrote:
> On Fri, 2015-10-09 at 13:59 +0100, Andrew Cooper wrote:
>> On 09/10/15 03:56, Konrad Rzeszutek Wilk wrote:
>>> +    rc = xc_version_len(ctx->xch, XENVER_build_id, &u.build_id,
>>> BUILD_ID_LEN);
>>> +    if (rc > 0) {
>>> +        unsigned int i;
>>> +
>>> +        info->build_id = (char *)malloc((rc * 2) + 1);
>>> +
>>> +        for (i = 0; i < rc && (i + 1) * 2 < BUILD_ID_LEN; i++)
>>> +            snprintf(&info->build_id[i * 2], 3, "%02hhx",
>>> u.build_id[i]);
>>> +
>>> +        info->build_id[i*2]='\0';
>>> +    } else
>>> +        info->build_id = strdup("");
>> info->build_id is unconditionally leaked, given this patch.
> It should be freed by libxl_version_info_dispose, which any correct callers
> should already be using.

Ah - so it will.  Sorry for the noise.

~Andrew