From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v3 7/9] xen/arm: vgic: Optimize the way to store the target vCPU in the rank Date: Mon, 12 Oct 2015 12:00:59 +0100 Message-ID: <561B92EB.1020206@citrix.com> References: <1444228871-383-1-git-send-email-julien.grall@citrix.com> <1444228871-383-8-git-send-email-julien.grall@citrix.com> <56156161.4090109@citrix.com> <1444301795.1410.148.camel@citrix.com> <1444307021.1410.170.camel@citrix.com> <561673A8.8050608@citrix.com> <1444314312.1410.206.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zlas5-0003Tk-Bl for xen-devel@lists.xenproject.org; Mon, 12 Oct 2015 11:02:25 +0000 In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini , Ian Campbell Cc: xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On 12/10/15 11:41, Stefano Stabellini wrote: > On Thu, 8 Oct 2015, Ian Campbell wrote: >>> If the concern is the behavior is changed, I'm happy to rework this code >>> to keep exactly the same behavior. I.e any 32-bit write containing >>> a 0 byte will be ignored. This is not optimal but at least I'm not >>> opening the pandora box of fixing every single error in the code touch >>> by this series. >> >> I'm okay with the new behaviour, I think Stefano was willing to tolerate it >> (based on ). >> >> So if we aren't going to fix it to DTRT WRT writing zero to a target then I >> think we can go with the current variant and not change to ignoring any >> word with a zero byte in it. > > OK. > > BTW it would be interesting to see how real hardware behaves in this > regard. I seem to recall that X-Gene was ignoring 0 writes too. What do you mean by 0 writes? Is it the write ignored if one byte is 0? Although, it's really depend if you try on a target register where all the byte correspond to an implemented field or not. Based on the spec (4.3.12 ARM IHI 0048B.b), a field corresponding to an interrupt not implemented (i.e not wired) is RAZ/WI. Regards, -- Julien Grall