From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] x86/ept: defer enabling of EPT A/D bit until PML get enabled. Date: Fri, 16 Oct 2015 12:01:13 +0100 Message-ID: <5620D8F9.8030209@citrix.com> References: <1444962075-6713-1-git-send-email-kai.huang@linux.intel.com> <5620CEA302000078000ABB79@prv-mh.provo.novell.com> <5620C0AA.4050602@linux.intel.com> <5620DF0C02000078000ABC48@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5620DF0C02000078000ABC48@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , Kai Huang Cc: george.dunlap@eu.citrix.com, kevin.tian@intel.com, jun.nakajima@intel.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 16/10/15 10:27, Jan Beulich wrote: >>>> On 16.10.15 at 11:17, wrote: >> On 10/16/2015 04:17 PM, Jan Beulich wrote: >>>>>> On 16.10.15 at 04:21, wrote: >>>> +void vmx_domain_update_eptp(struct domain *d) >>>> +{ >>>> + struct p2m_domain *p2m = p2m_get_hostp2m(d); >>>> + struct vcpu *v; >>>> + >>>> + ASSERT(atomic_read(&d->pause_count)); >>> This should imo check controller_pause_count. >> This function is called between domain_pause and domain_unpause, and >> domain_pause increases d->pause_count, not d->controller_pause_count, so >> we should check d->pause_count, right? > Ah, okay - I thought the pause was tool stack initiated. ept_enable_pml() is the subject of p2m->enable_hardware_log_dirty(), which happens during runtime with logdirty ops, etc. ~Andrew