From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH 1/2] xen/x86: Helpers for cpu feature manipuation
Date: Mon, 26 Oct 2015 12:42:30 +0000 [thread overview]
Message-ID: <562E1FB6.7020101@citrix.com> (raw)
In-Reply-To: <562E254902000078000AE91A@prv-mh.provo.novell.com>
On 26/10/15 12:06, Jan Beulich wrote:
>>>> On 26.10.15 at 12:17, <andrew.cooper3@citrix.com> wrote:
>> --- a/xen/arch/x86/cpu/common.c
>> +++ b/xen/arch/x86/cpu/common.c
>> @@ -202,7 +202,7 @@ static void __init early_cpu_detect(void)
>> c->x86_mask = tfms & 15;
>> cap0 &= ~cleared_caps[0];
>> cap4 &= ~cleared_caps[4];
>> - if (cap0 & (1<<19))
>> + if (cap0 & cpufeat_mask(X86_FEATURE_CLFLSH))
> This one's particularly well spotted! Thanks!
I doubt I have found all instances like this. I only found this one
because of the associated changes in the subsequent patch.
I will be fixing them as I find them.
~Andrew
next prev parent reply other threads:[~2015-10-26 12:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 11:17 [PATCH 0/2] xen/x86: Improvements to x86_capability[] handling Andrew Cooper
2015-10-26 11:17 ` [PATCH 1/2] xen/x86: Helpers for cpu feature manipuation Andrew Cooper
2015-10-26 12:06 ` Jan Beulich
2015-10-26 12:42 ` Andrew Cooper [this message]
2015-10-26 11:17 ` [PATCH 2/2] xen/x86: Remove assumptions about the layout of x86_capabilities Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562E1FB6.7020101@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).