From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ross Lagerwall Subject: Re: [PATCH v1 1/5] xsplice: Design document. Date: Mon, 26 Oct 2015 13:21:46 +0000 Message-ID: <562E28EA.2030101@citrix.com> References: <1442437276-2620-1-git-send-email-konrad.wilk@oracle.com> <1442437276-2620-2-git-send-email-konrad.wilk@oracle.com> <562E1620.30301@amazon.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqhip-0006do-Sz for xen-devel@lists.xenproject.org; Mon, 26 Oct 2015 13:22:00 +0000 In-Reply-To: <562E1620.30301@amazon.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Martin Pohlack Cc: elena.ufimtseva@oracle.com, hanweidong@huawei.com, jbeulich@suse.com, john.liuqiming@huawei.com, paul.voccio@rackspace.com, daniel.kiper@oracle.com, major.hayden@rackspace.com, liuyingdong@huawei.com, aliguori@amazon.com, xen-devel@lists.xenproject.org, lars.kurth@citrix.com, steven.wilson@rackspace.com, ian.campbell@citrix.com, peter.huangpeng@huawei.com, msw@amazon.com, xiantao.zxt@alibaba-inc.com, rick.harris@rackspace.com, boris.ostrovsky@oracle.com, josh.kearney@rackspace.com, jinsong.liu@alibaba-inc.com, amesserl@rackspace.com, fanhenglong@huawei.com, andrew.cooper3@citrix.com List-Id: xen-devel@lists.xenproject.org On 10/26/2015 12:01 PM, Martin Pohlack wrote: > On 16.09.2015 23:01, Konrad Rzeszutek Wilk wrote: > > [...] > >> +### xsplice_patch >> + >> +This structure has the binary code (or data) to be patched. Depending on the >> +type it can either an inline patch (data or text) or require an relocation >> +change (which requires a trampoline). Naturally it also points to a blob >> +of the binary data to patch in, and the size of the patch. > > On the Xen developer summit we agreed to start with a minimal approach > first. Based on looking at the last ~50 XSA patches, I do think we can > do *without* the in-place patching and would propose to tackle this > approach later or not at all. > Indeed. The prototype V1 that I posted last Friday works at a function level. I guess the only reason to make anything more complicated would be to patch the asm code in entry.S. -- Ross Lagerwall