From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@citrix.com>
Subject: Re: [PATCH v1] xen/serial: Return actual bytes stored
 in TX FIFO for OMAP
Date: Tue, 27 Oct 2015 10:54:49 +0000
Message-ID: <562F57F9.1020805@citrix.com>
References: <1445942183-1512-1-git-send-email-oleksandr.tyshchenko@globallogic.com>
	<562F652102000078000AF061@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <562F652102000078000AF061@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, Oleksandr Tyshchenko <oleksandr.tyshchenko@globallogic.com>
Cc: xen-devel@lists.xen.org, tim@xen.org, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On 27/10/15 10:50, Jan Beulich wrote:
>>>> On 27.10.15 at 11:36, <oleksandr.tyshchenko@globallogic.com> wrote:
>> --- a/xen/include/xen/8250-uart.h
>> +++ b/xen/include/xen/8250-uart.h
>> @@ -143,6 +143,15 @@
>>  /* Supplementary control register */
>>  #define UART_OMAP_SCR     0x10
> 
> I think this one is already misplaced here (as is the one in the context
> below the change).

I don't think so, the omap UART is based on the 8250 and share some
common registers.

FWIW, we do the same for ns16550.c which is using the 8250 headers...

Regards,

-- 
Julien Grall