From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v1] xen/serial: Return actual bytes stored in TX FIFO for OMAP Date: Tue, 27 Oct 2015 11:15:24 +0000 Message-ID: <562F5CCC.6080308@citrix.com> References: <1445942183-1512-1-git-send-email-oleksandr.tyshchenko@globallogic.com> <562F652102000078000AF061@prv-mh.provo.novell.com> <562F57F9.1020805@citrix.com> <562F689C02000078000AF089@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <562F689C02000078000AF089@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Oleksandr Tyshchenko , xen-devel@lists.xen.org, tim@xen.org, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 27/10/15 11:05, Jan Beulich wrote: >>>> On 27.10.15 at 11:54, wrote: >> On 27/10/15 10:50, Jan Beulich wrote: >>>>>> On 27.10.15 at 11:36, wrote: >>>> --- a/xen/include/xen/8250-uart.h >>>> +++ b/xen/include/xen/8250-uart.h >>>> @@ -143,6 +143,15 @@ >>>> /* Supplementary control register */ >>>> #define UART_OMAP_SCR 0x10 >>> >>> I think this one is already misplaced here (as is the one in the context >>> below the change). >> >> I don't think so, the omap UART is based on the 8250 and share some >> common registers. > > Well, if it's that way then the patch is fine, but I then question why > we have a separate omap-uart.c. I've got no clue, the omap is a superset of the 8250 and actually we already use the 8250 low-level serial for those platforms. Linux is also having a separate driver for the OMAP UART. Oleksandr, is there any fundamental difference between the OMAP and ns16550 driver? Regards, -- Julien Grall