From: David Vrabel <david.vrabel@citrix.com>
To: Jan Beulich <JBeulich@suse.com>, David Vrabel <david.vrabel@citrix.com>
Cc: xen-devel@lists.xenproject.org, Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCHv1 2/2] passthrough: improve locking when iterating over interrupts bound to VMs
Date: Tue, 27 Oct 2015 13:11:05 +0000 [thread overview]
Message-ID: <562F77E9.8020708@citrix.com> (raw)
In-Reply-To: <562F7FD402000078000AF1CA@prv-mh.provo.novell.com>
On 27/10/15 12:44, Jan Beulich wrote:
>>>> On 23.10.15 at 13:05, <david.vrabel@citrix.com> wrote:
>> radix_tree_gang_lookup() only requires a RCU read lock, not the
>> per-domain event_lock.
>
> ... when not caring about a consistent snapshot.
>
>> @@ -678,9 +684,7 @@ void hvm_dpci_msi_eoi(struct domain *d, int vector)
>> if ( !iommu_enabled || !d->arch.hvm_domain.irq.dpci )
>> return;
>>
>> - spin_lock(&d->event_lock);
>> pt_pirq_iterate(d, _hvm_dpci_msi_eoi, (void *)(long)vector);
>> - spin_unlock(&d->event_lock);
>> }
>
> How about other callers of pt_pirq_iterate()?
They weren't hot so I didn't look at them.
David
next prev parent reply other threads:[~2015-10-27 13:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 11:05 passthrough: improve interrupt injection locking David Vrabel
2015-10-23 11:05 ` [PATCHv1 1/2] passthrough: use per-interrupt lock when injecting an interrupt David Vrabel
2015-10-27 11:56 ` Jan Beulich
2015-10-28 20:18 ` Konrad Rzeszutek Wilk
2015-10-29 9:11 ` Jan Beulich
2015-10-30 14:45 ` Konrad Rzeszutek Wilk
2015-10-23 11:05 ` [PATCHv1 2/2] passthrough: improve locking when iterating over interrupts bound to VMs David Vrabel
2015-10-27 12:44 ` Jan Beulich
2015-10-27 13:11 ` David Vrabel [this message]
2015-10-28 20:42 ` Konrad Rzeszutek Wilk
2015-10-23 12:37 ` passthrough: improve interrupt injection locking Ian Campbell
2015-10-23 12:38 ` David Vrabel
2015-10-23 12:45 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562F77E9.8020708@citrix.com \
--to=david.vrabel@citrix.com \
--cc=JBeulich@suse.com \
--cc=ian.campbell@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).