From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] oxenstored: fix short-write issue
Date: Tue, 27 Oct 2015 17:31:37 +0000
Message-ID: <562FB4F9.20100@citrix.com>
References: <1445965809-5144-1-git-send-email-wei.liu2@citrix.com>
	<562FB2A3.8070603@citrix.com>
	<20151027172810.GQ2483@var.bordeaux.inria.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=7357aa5aa=Andrew.Cooper3@citrix.com>)
	id 1Zr861-00047A-M2
	for xen-devel@lists.xenproject.org; Tue, 27 Oct 2015 17:31:41 +0000
In-Reply-To: <20151027172810.GQ2483@var.bordeaux.inria.fr>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Samuel Thibault <samuel.thibault@ens-lyon.org>, Wei Liu <wei.liu2@citrix.com>, Xen-devel <xen-devel@lists.xenproject.org>, Ian
	Jackson <ian.jackson@eu.citrix.com>, Ian Campbell <ian.campbell@citrix.com>, David Scott <dave@recoil.org>
List-Id: xen-devel@lists.xenproject.org

On 27/10/15 17:28, Samuel Thibault wrote:
> Andrew Cooper, le Tue 27 Oct 2015 17:21:39 +0000, a =E9crit :
>> as the second attempted write could return short as well.
> That is fine. The second attempt will only return a short write if there
> was really not enough room for it, which is what we want.

Then surely the bug is that Xs_ring.write returns short when it shouldn't?

~Andrew