From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH for-4.6] xen/public: arm: Use __typeof__ rather than typeof Date: Wed, 28 Oct 2015 15:44:49 +0000 Message-ID: <5630ED71.7010700@citrix.com> References: <1443986642-24392-1-git-send-email-julien.grall@citrix.com> <562A3295.6010901@citrix.com> <1445607059.2374.165.camel@citrix.com> <562A57D902000078000AE2A2@prv-mh.provo.novell.com> <562A3D0D.3000806@citrix.com> <562A5D4402000078000AE310@prv-mh.provo.novell.com> <1445610702.2374.199.camel@citrix.com> <562A625102000078000AE347@prv-mh.provo.novell.com> <562A47B1.7030400@citrix.com> <1445612112.2374.213.camel@citrix.com> <562E6C09.90607@citrix.com> <562F3E6102000078000AEECD@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZrSvY-0005y0-8E for xen-devel@lists.xenproject.org; Wed, 28 Oct 2015 15:46:16 +0000 In-Reply-To: <562F3E6102000078000AEECD@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: KeirFraser , Ian Campbell , Stefano Stabellini , Tim Deegan , Ian Jackson , xen-devel@lists.xenproject.org, Wei.Liu2@citrix.com List-Id: xen-devel@lists.xenproject.org On 27/10/15 08:05, Jan Beulich wrote: >>>> On 26.10.15 at 19:08, wrote: >> However, IIUC, the get_xen_guest_handle is only exposed to the tools and >> therefore possible to modify it in order to pass the type. Am I wrong? >> FWIW, I haven't seen any usage in the tools directory. > > Indeed. Rather than worrying about getting it right, let's just drop it. > Patch sent a minute ago. On the same note, is there any reason we want to expose XEN_GUEST_HANDLE_PARAM to the guest? It has been introduced with ARM to represent a guest pointer as an hypercall pointer and only used within Xen to differentiate 32bit vs 64bit build. XEN_GUEST_HANDLE will be different when built for 32-bit/64-bit as will not really have any meaning from the guest POV. Regards, -- Julien Grall