From mboxrd@z Thu Jan  1 00:00:00 1970
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v3 9/9] libxc: create p2m list outside of
 kernel mapping if supported
Date: Thu, 29 Oct 2015 14:19:57 +0100
Message-ID: <56321CFD.30503@suse.com>
References: <1444741878-16610-1-git-send-email-jgross@suse.com>
	<1444741878-16610-10-git-send-email-jgross@suse.com>
	<20151029130726.GN18674@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20151029130726.GN18674@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: roger.pau@citrix.com, stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, Ian.Campbell@citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 10/29/2015 02:07 PM, Wei Liu wrote:
> On Tue, Oct 13, 2015 at 03:11:18PM +0200, Juergen Gross wrote:
> [...]
>>    err:
>> diff --git a/tools/libxc/xc_dom_x86.c b/tools/libxc/xc_dom_x86.c
>> index 333ef6b..0847761 100644
>> --- a/tools/libxc/xc_dom_x86.c
>> +++ b/tools/libxc/xc_dom_x86.c
>> @@ -68,6 +68,8 @@
>>   #define bits_to_mask(bits)       (((xen_vaddr_t)1 << (bits)) - 1)
>>   #define round_down(addr, mask)   ((addr) & ~(mask))
>>   #define round_up(addr, mask)     ((addr) | (mask))
>> +#define round_pg(addr)    (((addr) + PAGE_SIZE_X86 - 1) & ~(PAGE_SIZE_X86 - 1))
>
> Minor suggestion: rename this to round_pgup to make it more explicit?

Yes, this is better.

>
>> +#define round_pfn(addr)   (((addr) + PAGE_SIZE_X86 - 1) / PAGE_SIZE_X86)
>>
>
> And this to round_pfnup?

Yes.

>
>>   struct xc_dom_x86_mapping_lvl {
>>       xen_vaddr_t from;
>> @@ -84,7 +86,7 @@ struct xc_dom_x86_mapping {
>>
>>   struct xc_dom_image_x86 {
>>       unsigned n_mappings;
>> -#define MAPPING_MAX 1
>> +#define MAPPING_MAX 2
>>       struct xc_dom_x86_mapping maps[MAPPING_MAX];
>>   };
>>
>> @@ -536,6 +538,7 @@ static int setup_pgtables_x86_64(struct xc_dom_image *dom)
>>               }
>>           }
>>       }
>> +
>
> Stay blank line.

Will remove.

>
> Other than that:
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>


Thanks,

Juergen