From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Vladimir_'=cf=86-coder/phcoder'_Serbinenko?= Subject: Re: [PATCH v3 3/4] * util/grub.d/20_linux_xen.in: Add support of the XEN boot on aarch64 Date: Thu, 29 Oct 2015 16:25:38 +0100 Message-ID: <56323A72.3000905@gmail.com> References: <=fu.wei@linaro.org> <1437628583-23667-1-git-send-email-fu.wei@linaro.org> <1437628583-23667-4-git-send-email-fu.wei@linaro.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3379651579872740133==" Return-path: In-Reply-To: <1437628583-23667-4-git-send-email-fu.wei@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: fu.wei@linaro.org, grub-devel@gnu.org, arvidjaar@gmail.com Cc: xen-devel@lists.xensource.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, jcm@redhat.com, leif.lindholm@linaro.org, ryan.harkin@linaro.org, linaro-uefi@lists.linaro.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============3379651579872740133== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ijgqTQ8oVnfHe6HkwvF0uhpo4axrELrXQ" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ijgqTQ8oVnfHe6HkwvF0uhpo4axrELrXQ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable > +if [ "x$machine" !=3D xaarch64 ]; then > + multiboot_cmd=3D"multiboot" > + module_linux_cmd=3D"module" > + module_initrd_cmd=3D"module --nounzip" > +else > + multiboot_cmd=3D"xen_hypervisor" > + module_linux_cmd=3D"xen_linux" > + module_initrd_cmd=3D"xen_initrd" > +fi > + Please do not hardcode an assumption that grub-mkconfig is executed on the same machine as GRUB is booted. I know that we have instances of such assumption in some cases but we'd like to eliminate them. Alternativ= es: - Check arch on boot time - Check that new xen commands are supported (define a new feature) Please add xen_* aliases on x86 as well --ijgqTQ8oVnfHe6HkwvF0uhpo4axrELrXQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iF4EAREKAAYFAlYyOnIACgkQmBXlbbo5nOu4wgD/drM87iFnLsaX14sr05ZrT6JA 4V5j7Q2AbDWlSwxNszcBAKNlgG4k7a4fw+hPGAHoapS87rjrRdoJJM9ZJYWdoQmK =U10v -----END PGP SIGNATURE----- --ijgqTQ8oVnfHe6HkwvF0uhpo4axrELrXQ-- --===============3379651579872740133== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============3379651579872740133==--