Re: [PATCH v5 1/9] libxc: reorganize domain builder guest memory allocator

[Juergen Gross <jgross@suse.com>]

On 12/11/15 16:55, Wei Liu wrote:
> On Thu, Nov 12, 2015 at 04:27:14PM +0100, Juergen Gross wrote:
>> On 12/11/15 15:47, Ian Campbell wrote:
>>> On Thu, 2015-11-12 at 15:03 +0100, Juergen Gross wrote:
>>>> On 12/11/15 14:48, Wei Liu wrote:
>>>>> On Thu, Nov 12, 2015 at 02:43:28PM +0100, Juergen Gross wrote:
>>>>>> Guest memory allocation in the domain builder of libxc is done via
>>>>>> virtual addresses only. In order to be able to support preallocated
>>>>>> areas not virtually mapped reorganize the memory allocator to keep
>>>>>> track of allocated pages globally and in allocated segments.
>>>>>>
>>>>>> This requires an interface change of the allocate callback of the
>>>>>> domain builder which currently is using the last mapped virtual
>>>>>> address as a parameter. This is no problem as the only user of this
>>>>>> callback is stubdom/grub/kexec.c using this virtual address to
>>>>>> calculate the last used pfn.
>>>>>>
>>>>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>>>>
>>>>> If you've tested and confirmed pvgrub (stubdom based grub) doesn't
>>>>> break:
>>>>>
>>>>> Acked-by: Wei Liu <wei.liu2@citrix.com>
>>>>>
>>>>
>>>> Hmm, difficult. Is this ever tested automatically?
>>>
>>> Yes, see the test-amd64-amd64-amd64-pvgrub and test-amd64-amd64-i386-pvgrub 
>>> jobs in any recent osstest flight (it was added a couple of months back.
>>>
>>> http://logs.test-lab.xenproject.org/osstest/results/history/test-amd64-amd64-amd64-pvgrub/xen-unstable.html
>>>
>>> suggests it works ok in general.
>>
>> It doesn't work on any of my test installations I've tried
>> so far (3 different installations with 3 different domUs).
>> And that's without my patches being active.
>>
>> In case somebody else is capable of testing pvgrub with
>> xen-unstable I'd appreciate testing my patches there!
>>
> 
> I played with the pvgrub generated with this series, it can boot Debian
> Wheezy stock 3.2 kernel.

Thanks for testing this!


Juergen