From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, roger.pau@citrix.com
Subject: Re: [PATCH v2 2/3] xen/hvm: introduce a fpu_uninitialised field to the CPU save record
Date: Wed, 18 Nov 2015 11:24:34 +0000 [thread overview]
Message-ID: <564C5FF2.4090508@citrix.com> (raw)
In-Reply-To: <564C693F02000078000B6396@prv-mh.provo.novell.com>
On 18/11/15 11:04, Jan Beulich wrote:
>>>> On 18.11.15 at 12:00, <andrew.cooper3@citrix.com> wrote:
>> As for the problem at hand, I don't see what was wrong with v1.
>>
>> Fundamentally, we have three different variations of the same structure;
>> two of which require special compat handling. Pretending otherwise is
>> just silly.
> And if we gain a few more additions, we'll end up with half a dozen
> slightly different structure declarations in the public interface? If
> you consider the first step (adding tsc_aux) a mistake, let's not
> repeat the same mistake again (even if right now it might _seem_
> to be reasonable to some of us).
As part of cpuid handling fixes, I will be removing all of this from the
hypervisor
The result doesn't need to live very long; I would recommend the route
which has more-obvious-correct code. I am not fussed as to which route
this ends up being.
~Andrew
next prev parent reply other threads:[~2015-11-18 11:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 18:44 [PATCH v2 0/3] Introduce a fpu_initilised filed to HVM CPU context Roger Pau Monne
2015-11-17 18:44 ` [PATCH v2 1/3] xen/save: pass a size paramter to the HVM compat functions Roger Pau Monne
2015-11-17 18:50 ` Andrew Cooper
2015-11-17 18:44 ` [PATCH v2 2/3] xen/hvm: introduce a fpu_uninitialised field to the CPU save record Roger Pau Monne
2015-11-17 19:02 ` Andrew Cooper
2015-11-18 10:51 ` Roger Pau Monné
2015-11-18 11:00 ` Andrew Cooper
2015-11-18 11:04 ` Jan Beulich
2015-11-18 11:24 ` Andrew Cooper [this message]
2015-11-17 18:44 ` [PATCH v2 3/3] Revert "libxc: create an initial FPU state for HVM guests" Roger Pau Monne
2015-11-17 19:03 ` Andrew Cooper
2015-11-18 9:57 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564C5FF2.4090508@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).