From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v2 2/3] xen/hvm: introduce a fpu_uninitialised field to the CPU save record Date: Wed, 18 Nov 2015 11:24:34 +0000 Message-ID: <564C5FF2.4090508@citrix.com> References: <1447785879-32574-1-git-send-email-roger.pau@citrix.com> <1447785879-32574-3-git-send-email-roger.pau@citrix.com> <564B79AD.6040703@citrix.com> <564C581E.10008@citrix.com> <564C5A59.2060500@citrix.com> <564C693F02000078000B6396@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zz0rB-00086d-By for xen-devel@lists.xenproject.org; Wed, 18 Nov 2015 11:24:57 +0000 In-Reply-To: <564C693F02000078000B6396@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel@lists.xenproject.org, roger.pau@citrix.com List-Id: xen-devel@lists.xenproject.org On 18/11/15 11:04, Jan Beulich wrote: >>>> On 18.11.15 at 12:00, wrote: >> As for the problem at hand, I don't see what was wrong with v1. >> >> Fundamentally, we have three different variations of the same structure; >> two of which require special compat handling. Pretending otherwise is >> just silly. > And if we gain a few more additions, we'll end up with half a dozen > slightly different structure declarations in the public interface? If > you consider the first step (adding tsc_aux) a mistake, let's not > repeat the same mistake again (even if right now it might _seem_ > to be reasonable to some of us). As part of cpuid handling fixes, I will be removing all of this from the hypervisor The result doesn't need to live very long; I would recommend the route which has more-obvious-correct code. I am not fussed as to which route this ends up being. ~Andrew