From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH v5 8/9] libxc: rework of domain builder's page table handler Date: Wed, 18 Nov 2015 11:11:16 -0500 Message-ID: <564CA324.5040005@oracle.com> References: <1447335816-31772-1-git-send-email-jgross@suse.com> <1447335816-31772-9-git-send-email-jgross@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1447335816-31772-9-git-send-email-jgross@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Juergen Gross , xen-devel@lists.xen.org, Ian.Campbell@citrix.com, ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.com, wei.liu2@citrix.com, roger.pau@citrix.com List-Id: xen-devel@lists.xenproject.org On 11/12/2015 08:43 AM, Juergen Gross wrote: > In order to prepare a p2m list outside of the initial kernel mapping > do a rework of the domain builder's page table handler. The goal is > to be able to use common helpers for page table allocation and setup > for initial kernel page tables and page tables mapping the p2m list. > This is achieved by supporting multiple mapping areas. The mapped > virtual addresses of the single areas must not overlap, while the > page tables of a new area added might already be partially present. > Especially the top level page table is existing only once, of course. > > Currently restrict the number of mappings to 1 because the only mapping > now is the initial mapping created by toolstack. There should not be > behaviour change and guest visible change introduced. > > Signed-off-by: Juergen Gross > Reviewed-by: Wei Liu --- > tools/libxc/xc_dom_x86.c | 479 ++++++++++++++++++++++++----------------------- > tools/libxc/xg_private.h | 39 +--- > 2 files changed, 252 insertions(+), 266 deletions(-) This broke PVH. I get a triple fault (somewhere in clear_page(), so the guest have run a little) -boris