From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@citrix.com>
Subject: Re: [PATCH v5 1/6] xen/arm: vgic-v2: Implement
 correctly ITARGETSR0 - ITARGETSR7 read-only
Date: Wed, 18 Nov 2015 16:20:46 +0000
Message-ID: <564CA55E.4010805@citrix.com>
References: <1447084181-13677-1-git-send-email-julien.grall@citrix.com>
	<1447084181-13677-2-git-send-email-julien.grall@citrix.com>
	<1447680234.27871.87.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=7574aa55f=julien.grall@citrix.com>)
	id 1Zz5Ur-00027F-G1
	for xen-devel@lists.xenproject.org; Wed, 18 Nov 2015 16:22:13 +0000
In-Reply-To: <1447680234.27871.87.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xenproject.org
Cc: stefano.stabellini@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On 16/11/15 13:23, Ian Campbell wrote:
> On Mon, 2015-11-09 at 15:49 +0000, Julien Grall wrote:
>>  #define GICD_ITARGETSR  (0x800)
>> +#define GICD_ITARGETSR7 (0x81C)
>> +#define GICD_ITARGETSR8 (0x820)
> 
> As a future change, I wonder if making these take a parameter (N) and do
> the necessary arithmetic would be less error prone?

That would be an improvement.

Regards,

-- 
Julien Grall