From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shannon Zhao Subject: Re: [PATCH v2 05/11] xen/arm: vgic: Properly emulate the full register Date: Wed, 25 Nov 2015 17:26:56 +0800 Message-ID: <56557EE0.6010507@huawei.com> References: <1447867686-19371-1-git-send-email-julien.grall@citrix.com> <1447867686-19371-6-git-send-email-julien.grall@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1a1WTW-0007Fp-Tg for xen-devel@lists.xenproject.org; Wed, 25 Nov 2015 09:34:55 +0000 In-Reply-To: <1447867686-19371-6-git-send-email-julien.grall@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall , xen-devel@lists.xenproject.org Cc: ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org Hi Julien, On 2015/11/19 1:28, Julien Grall wrote: > - case GICD_ICACTIVER ... GICD_ICACTIVERN: > + case VRANGE32(GICD_ICACTIVER, GICD_ICACTIVERN): > if ( dabt.size != DABT_WORD ) goto bad_width; > printk(XENLOG_G_ERR > "%pv: vGICD: unhandled word write %#"PRIregister" to ICACTIVER%d\n", > v, r, gicd_reg - GICD_ICACTIVER); > return 0; Maybe this question is not related to what this patch does. But I have a problem when I rebase my ACPI patches on upstream Linux kernel. Upstream Linux kernel applies below patch which will write GICD_ICACTIVER. But since Xen doesn't support it, so it will cause Dom0 initializes GIC failed. 0eece2b22849c90b730815c893425a36b9d10fd5 (irqchip/gic: Make sure all interrupts are deactivated at boot) (XEN) d0v0: vGICD: unhandled word write 0xffffffff to ICACTIVER4 (XEN) traps.c:2447:d0v0 HSR=0x93860046 pc=0xffffffc0008d63f0 gva=0xffffff8000004384 gpa=0x0000002f000384 (XEN) DOM0: Unhandled fault: ttbr address size fault (0x96000000) at 0xffffff8000004384 (XEN) DOM0: Internal error: : 96000000 [#1] PREEMPT SMP (XEN) DOM0: Modules linked in: (XEN) DOM0: CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.4.0-rc2+ #364 (XEN) DOM0: Hardware name: (null) (DT) (XEN) DOM0: task: ffffffc000969970 ti: ffffffc00095c000 task.ti: ffffffc00095c000 (XEN) DOM0: PC is at gic_dist_config+0x78/0xa0 (XEN) DOM0: LR is at __gic_init_bases+0x240/0x2bc Do we have a plan to fix this? Thanks, -- Shannon