From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 01/11] xen/arm: vgic-v2: Implement correctly ICFGR{0, 1} read-only Date: Mon, 30 Nov 2015 12:11:28 +0000 Message-ID: <565C3CF0.1030008@citrix.com> References: <1447867686-19371-1-git-send-email-julien.grall@citrix.com> <1447867686-19371-2-git-send-email-julien.grall@citrix.com> <1448385257.26412.71.camel@citrix.com> <1448454564.17688.97.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1a3NKB-0007E8-79 for xen-devel@lists.xenproject.org; Mon, 30 Nov 2015 12:12:55 +0000 In-Reply-To: <1448454564.17688.97.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , xen-devel@lists.xenproject.org Cc: stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org Hi Ian, On 25/11/15 12:29, Ian Campbell wrote: > On Tue, 2015-11-24 at 17:14 +0000, Ian Campbell wrote: >> @@ -507,10 +507,12 @@ static int vgic_v2_distr_mmio_write(struct vcpu >>> *v, >>> mmio_info_t *info, >>> >>> case GICD_ICFGR: /* SGIs */ >>> goto write_ignore_32; >>> - case GICD_ICFGR + 1: /* PPIs */ >>> + >>> + case GICD_ICFGR1: >> >> This should have a /* PPIs */ comment I think? >> >> I think I could add that on commit if you agree. > > With you being away this week I decided this wasn't worth holding up 11 > patches over and committed without. Instead: FWIW, I'm fine with that as it was a mistake while I wrote the patch. Regards, -- Julien Grall